ehmry/genode
ehmry
/
genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sculpt: don't reset hover on click on '+' menu 

When entering/leaving sub menus of Sculpt's '+' menu, some parts of the
menu sometimes remain unchanged, in particular the back button.
Originally, a click would reset the hovering on clicks in the
expectation that any click would eventually result in a completely new
situation where the old hovering information does not make sense and
would only (potentially) confuse the menu. But this was apparently
overzealous. With the patch a once hovered back button stays hovered
even when actitivated and the back button of the upper-level menu
happens to stay under the current pointer position.

Issue #3209
This commit is contained in:
Norman Feske 2019-03-08 15:03:27 +01:00 committed by Christian Helmuth
parent 014e800e8a
commit 669aed0ac0
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
repos/gems/src/app/sculpt_manager/view/popup_dialog.cc
View File

@ -257,7 +257,6 @@ void Popup_dialog::_gen_menu_elements(Xml_generator &xml) const
void Popup_dialog::click(Action &action)
{
Hoverable_item::Id const clicked = _item._hovered;
_item._hovered = Hoverable_item::Id();
_action_item .propose_activation_on_click();
_install_item.propose_activation_on_click();