From 669aed0ac0d26d6b7752df2f2daab376682add03 Mon Sep 17 00:00:00 2001 From: Norman Feske Date: Fri, 8 Mar 2019 15:03:27 +0100 Subject: [PATCH] sculpt: don't reset hover on click on '+' menu When entering/leaving sub menus of Sculpt's '+' menu, some parts of the menu sometimes remain unchanged, in particular the back button. Originally, a click would reset the hovering on clicks in the expectation that any click would eventually result in a completely new situation where the old hovering information does not make sense and would only (potentially) confuse the menu. But this was apparently overzealous. With the patch a once hovered back button stays hovered even when actitivated and the back button of the upper-level menu happens to stay under the current pointer position. Issue #3209 --- repos/gems/src/app/sculpt_manager/view/popup_dialog.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc b/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc index df68cac54..15eeec1c6 100644 --- a/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc +++ b/repos/gems/src/app/sculpt_manager/view/popup_dialog.cc @@ -257,7 +257,6 @@ void Popup_dialog::_gen_menu_elements(Xml_generator &xml) const void Popup_dialog::click(Action &action) { Hoverable_item::Id const clicked = _item._hovered; - _item._hovered = Hoverable_item::Id(); _action_item .propose_activation_on_click(); _install_item.propose_activation_on_click();