Review doc and style for release. ref #69

This commit is contained in:
Martin Stein 2012-02-22 16:14:41 +01:00 committed by Norman Feske
parent 70ae53fe3c
commit bf7a5c2b69
2 changed files with 115 additions and 62 deletions

View File

@ -44,11 +44,12 @@ namespace Genode
/** /**
* An integer like region within a MMIO region. * An integer like region within a MMIO region.
* *
* \param _OFFSET Offset of the region relative to the base * \param _OFFSET Offset of the region relative to the
* of the compound MMIO. * base of the compound MMIO
* \param _ACCESS_WIDTH Bit width of the region. * \param _ACCESS_WIDTH Bit width of the region, for a list of
* supported widths see 'Genode::Register'
* *
* \detail See 'Genode::Register' * \detail See 'Genode::Register'
*/ */
template <off_t _OFFSET, unsigned long _ACCESS_WIDTH> template <off_t _OFFSET, unsigned long _ACCESS_WIDTH>
struct Register : public Genode::Register<_ACCESS_WIDTH> struct Register : public Genode::Register<_ACCESS_WIDTH>
@ -60,14 +61,16 @@ namespace Genode
/** /**
* A region within a register * A region within a register
* *
* \param _SHIFT Bit shift of the first bit within the compound register * \param _SHIFT Bit shift of the first bit within the
* compound register
* \param _WIDTH Bit width of the region * \param _WIDTH Bit width of the region
* *
* \detail See 'Genode::Register::Bitfield' * \detail See 'Genode::Register::Bitfield'
*/ */
template <unsigned long _SHIFT, unsigned long _WIDTH> template <unsigned long _SHIFT, unsigned long _WIDTH>
struct Bitfield : public Genode::Register<ACCESS_WIDTH>::template Bitfield<_SHIFT, _WIDTH> struct Bitfield :
public Genode::Register<ACCESS_WIDTH>::template Bitfield<_SHIFT, _WIDTH>
{ {
/** /**
* Back reference to containing register * Back reference to containing register
@ -79,26 +82,33 @@ namespace Genode
/** /**
* An array of successive equally structured regions * An array of successive equally structured regions
* *
* \param _OFFSET Offset of the first region relative to the base * \param _OFFSET Offset of the first region relative to
* of the compound MMIO. * the base of the compound MMIO.
* \param _ACCESS_WIDTH Bit width of a single access, must be at least * \param _ACCESS_WIDTH Bit width of a single access, must be at
* the item width. * least the item width.
* \param _ITEMS How many times the region gets iterated successive * \param _ITEMS How many times the region gets iterated
* successive
* \param _ITEM_WIDTH Bit width of a region * \param _ITEM_WIDTH Bit width of a region
* *
* \detail The array takes all inner structures, wich are covered by an item * \detail The array takes all inner structures, wich are covered
* width and iterates them successive. Such structures that are partially * by an item width and iterates them successive. Such
* exceed an item range are read and written also partially. Structures that are * structures that are partially exceed an item range are
* completely out of the item range are read as '0' and trying to overwrite * read and written also partially. Structures that are
* them has no effect. The array is not limited to its access width, it extends to * completely out of the item range are read as '0' and
* the memory region of its successive items. Trying to read out read with an item * trying to overwrite them has no effect. The array is
* index out of the array range returns '0', trying to write to such indices * not limited to its access width, it extends to the
* has no effect * memory region of its successive items. Trying to read
* out read with an item index out of the array range
* returns '0', trying to write to such indices has no
* effect
*/ */
template <off_t _OFFSET, unsigned long _ACCESS_WIDTH, unsigned long _ITEMS, unsigned long _ITEM_WIDTH> template <off_t _OFFSET, unsigned long _ACCESS_WIDTH,
unsigned long _ITEMS, unsigned long _ITEM_WIDTH>
struct Register_array : public Register<_OFFSET, _ACCESS_WIDTH> struct Register_array : public Register<_OFFSET, _ACCESS_WIDTH>
{ {
typedef typename Trait::Uint_type<_ACCESS_WIDTH>::template Divisor<_ITEM_WIDTH> Item; typedef
typename Trait::Uint_type<_ACCESS_WIDTH>::template Divisor<_ITEM_WIDTH>
Item;
enum { enum {
OFFSET = _OFFSET, OFFSET = _OFFSET,
@ -111,7 +121,8 @@ namespace Genode
ITEM_MASK = (1 << ITEM_WIDTH) - 1, ITEM_MASK = (1 << ITEM_WIDTH) - 1,
}; };
typedef typename Register<OFFSET, ACCESS_WIDTH>::access_t access_t; typedef typename Register<OFFSET, ACCESS_WIDTH>::access_t
access_t;
/** /**
* A bitregion within a register array item * A bitregion within a register array item
@ -119,26 +130,38 @@ namespace Genode
* \param _SHIFT Bit shift of the first bit within an item * \param _SHIFT Bit shift of the first bit within an item
* \param _WIDTH Bit width of the region * \param _WIDTH Bit width of the region
* *
* \detail See 'Genode::Register::Bitfield' * \detail See 'Genode::Register::Bitfield'
*/ */
template <unsigned long _SHIFT, unsigned long _SIZE> template <unsigned long _SHIFT, unsigned long _SIZE>
struct Bitfield : public Register<OFFSET, ACCESS_WIDTH>::template Bitfield<_SHIFT, _SIZE> struct Bitfield :
public Register<OFFSET, ACCESS_WIDTH>::template Bitfield<_SHIFT, _SIZE>
{ {
/** /**
* Back reference to containing register array * Back reference to containing register array
*/ */
typedef Register_array<OFFSET, ACCESS_WIDTH, ITEMS, ITEM_WIDTH> Compound_array; typedef Register_array<OFFSET, ACCESS_WIDTH, ITEMS, ITEM_WIDTH>
Compound_array;
}; };
/** /**
* Calculate the MMIO-relative offset 'offset' and shift 'shift' * Calculate destination of an array-item access
* within the according 'access_t' instance to access item 'index' *
* \param offset Gets overridden with the offset of the
* access type instance, that contains the
* access destination, relative to the MMIO
* base
* \param shift Gets overridden with the shift of the
* destination within the access type instance
* targeted by 'offset'
* \param index Index of the targeted array item
*/ */
static inline void access_dest(off_t & offset, unsigned long & shift, static inline void access_dest(off_t & offset,
unsigned long & shift,
unsigned long const index) unsigned long const index)
{ {
unsigned long const bit_off = index << ITEM_WIDTH_LOG2; unsigned long const bit_off = index << ITEM_WIDTH_LOG2;
offset = (off_t) ((bit_off >> BYTE_WIDTH_LOG2) & ~(sizeof(access_t)-1) ); offset = (off_t) ((bit_off >> BYTE_WIDTH_LOG2)
& ~(sizeof(access_t)-1) );
shift = bit_off - ( offset << BYTE_WIDTH_LOG2 ); shift = bit_off - ( offset << BYTE_WIDTH_LOG2 );
offset += OFFSET; offset += OFFSET;
} }
@ -189,7 +212,8 @@ namespace Genode
* Write value to the bitfield 'BITFIELD' * Write value to the bitfield 'BITFIELD'
*/ */
template <typename BITFIELD> template <typename BITFIELD>
inline void write(typename BITFIELD::Compound_reg::access_t const value); inline void
write(typename BITFIELD::Compound_reg::access_t const value);
/******************************* /*******************************
@ -200,10 +224,11 @@ namespace Genode
* Read the whole item 'index' of the array 'REGISTER_ARRAY' * Read the whole item 'index' of the array 'REGISTER_ARRAY'
*/ */
template <typename REGISTER_ARRAY> template <typename REGISTER_ARRAY>
inline typename REGISTER_ARRAY::access_t read(unsigned long const index) const; inline typename REGISTER_ARRAY::access_t
read(unsigned long const index) const;
/** /**
* Write 'value' to item 'index' of the array 'REGISTER_ARRAY' * Write 'value' to item 'index' of the array 'REGISTER_ARRAY'
*/ */
template <typename REGISTER_ARRAY> template <typename REGISTER_ARRAY>
inline void write(typename REGISTER_ARRAY::access_t const value, inline void write(typename REGISTER_ARRAY::access_t const value,
@ -215,16 +240,21 @@ namespace Genode
*****************************************************/ *****************************************************/
/** /**
* Read the bitfield 'ARRAY_BITFIELD' of item 'index' of the compound reg array * Read the bitfield 'ARRAY_BITFIELD' of item 'index' of the
* compound reg array
*/ */
template <typename ARRAY_BITFIELD> template <typename ARRAY_BITFIELD>
inline typename ARRAY_BITFIELD::Compound_array::access_t read(unsigned long const index) const; inline typename ARRAY_BITFIELD::Compound_array::access_t
read(unsigned long const index) const;
/** /**
* Write 'value' to bitfield 'ARRAY_BITFIELD' of item 'index' of the compound reg array * Write 'value' to bitfield 'ARRAY_BITFIELD' of item 'index' of
* the compound reg array
*/ */
template <typename ARRAY_BITFIELD> template <typename ARRAY_BITFIELD>
inline void write(typename ARRAY_BITFIELD::Compound_array::access_t const value, long unsigned const index); inline void
write(typename ARRAY_BITFIELD::Compound_array::access_t const value,
long unsigned const index);
}; };
} }
@ -304,7 +334,8 @@ void Genode::Mmio::write(typename BITFIELD::Compound_reg::access_t const value)
template <typename REGISTER_ARRAY> template <typename REGISTER_ARRAY>
typename REGISTER_ARRAY::access_t Genode::Mmio::read(unsigned long const index) const typename REGISTER_ARRAY::access_t
Genode::Mmio::read(unsigned long const index) const
{ {
/** /**
* Handle array overflow * Handle array overflow
@ -318,14 +349,16 @@ typename REGISTER_ARRAY::access_t Genode::Mmio::read(unsigned long const index)
*/ */
if (REGISTER_ARRAY::ITEM_WIDTH == REGISTER_ARRAY::ACCESS_WIDTH) { if (REGISTER_ARRAY::ITEM_WIDTH == REGISTER_ARRAY::ACCESS_WIDTH) {
offset = REGISTER_ARRAY::OFFSET + (index << REGISTER_ARRAY::ITEM_WIDTH_LOG2); offset = REGISTER_ARRAY::OFFSET
+ (index << REGISTER_ARRAY::ITEM_WIDTH_LOG2);
return _read<typename REGISTER_ARRAY::access_t>(offset); return _read<typename REGISTER_ARRAY::access_t>(offset);
} else { } else {
long unsigned shift; long unsigned shift;
REGISTER_ARRAY::access_dest(offset, shift, index); REGISTER_ARRAY::access_dest(offset, shift, index);
return (_read<typename REGISTER_ARRAY::access_t>(offset) >> shift) & REGISTER_ARRAY::ITEM_MASK; return (_read<typename REGISTER_ARRAY::access_t>(offset) >> shift)
& REGISTER_ARRAY::ITEM_MASK;
} }
} }
@ -347,7 +380,8 @@ void Genode::Mmio::write(typename REGISTER_ARRAY::access_t const value,
*/ */
if (REGISTER_ARRAY::ITEM_WIDTH == REGISTER_ARRAY::ACCESS_WIDTH) { if (REGISTER_ARRAY::ITEM_WIDTH == REGISTER_ARRAY::ACCESS_WIDTH) {
offset = REGISTER_ARRAY::OFFSET + (index << REGISTER_ARRAY::ITEM_WIDTH_LOG2); offset = REGISTER_ARRAY::OFFSET
+ (index << REGISTER_ARRAY::ITEM_WIDTH_LOG2);
_write<typename REGISTER_ARRAY::access_t>(offset, value); _write<typename REGISTER_ARRAY::access_t>(offset, value);
} else { } else {
@ -358,7 +392,9 @@ void Genode::Mmio::write(typename REGISTER_ARRAY::access_t const value,
/** /**
* Insert new value into old register value * Insert new value into old register value
*/ */
typename REGISTER_ARRAY::access_t new_reg = _read<typename REGISTER_ARRAY::access_t>(offset); typename REGISTER_ARRAY::access_t new_reg =
_read<typename REGISTER_ARRAY::access_t>(offset);
new_reg &= ~(REGISTER_ARRAY::ITEM_MASK << shift); new_reg &= ~(REGISTER_ARRAY::ITEM_MASK << shift);
new_reg |= (value & REGISTER_ARRAY::ITEM_MASK) << shift; new_reg |= (value & REGISTER_ARRAY::ITEM_MASK) << shift;
@ -373,8 +409,9 @@ void Genode::Mmio::write(typename REGISTER_ARRAY::access_t const value,
template <typename ARRAY_BITFIELD> template <typename ARRAY_BITFIELD>
void Genode::Mmio::write(typename ARRAY_BITFIELD::Compound_array::access_t const value, void
long unsigned const index) Genode::Mmio::write(typename ARRAY_BITFIELD::Compound_array::access_t const value,
long unsigned const index)
{ {
typedef typename ARRAY_BITFIELD::Compound_array Register_array; typedef typename ARRAY_BITFIELD::Compound_array Register_array;
@ -387,7 +424,8 @@ void Genode::Mmio::write(typename ARRAY_BITFIELD::Compound_array::access_t const
template <typename ARRAY_BITFIELD> template <typename ARRAY_BITFIELD>
typename ARRAY_BITFIELD::Compound_array::access_t Genode::Mmio::read(long unsigned const index) const typename ARRAY_BITFIELD::Compound_array::access_t
Genode::Mmio::read(long unsigned const index) const
{ {
typedef typename ARRAY_BITFIELD::Compound_array Array; typedef typename ARRAY_BITFIELD::Compound_array Array;
typedef typename Array::access_t access_t; typedef typename Array::access_t access_t;

View File

@ -1,5 +1,5 @@
/* /*
* \brief Generic access framework for highly structured memory regions * \brief Generic accessor framework for highly structured memory regions
* \author Martin stein * \author Martin stein
* \date 2011-11-10 * \date 2011-11-10
*/ */
@ -21,17 +21,22 @@ namespace Genode
namespace Trait { namespace Trait {
/** /**
* Get unsigned integer type for a given access width * Properties of integer types with a given bitwidth
*/ */
template <unsigned long _WIDTH> struct Uint_type; template <unsigned long _WIDTH> struct Uint_type;
/***************************************************************
** Provide the integer type and the width as exponent to the **
** base of 2 for all supported widths in 'Uint_type' **
***************************************************************/
template <> struct Uint_type<8> template <> struct Uint_type<8>
{ {
typedef uint8_t Type; typedef uint8_t Type;
enum { WIDTH_LOG2 = 3 }; enum { WIDTH_LOG2 = 3 };
/** /**
* Declare dividers of the compound type width * Access widths, wich are dividers to the compound type width
*/ */
template <unsigned long _DIVISOR_WIDTH> struct Divisor; template <unsigned long _DIVISOR_WIDTH> struct Divisor;
}; };
@ -54,10 +59,16 @@ namespace Genode
enum { WIDTH_LOG2 = 6 }; enum { WIDTH_LOG2 = 6 };
}; };
template <> struct Uint_type<8>::Divisor<1> { enum { WIDTH_LOG2 = 0 }; };
template <> struct Uint_type<8>::Divisor<2> { enum { WIDTH_LOG2 = 1 }; }; /********************************************************************
template <> struct Uint_type<8>::Divisor<4> { enum { WIDTH_LOG2 = 2 }; }; ** Provide widths as exponents to the base of 2 for all supported **
template <> struct Uint_type<8>::Divisor<8> { enum { WIDTH_LOG2 = 3 }; }; ** access widths in 'Uint_type::Divisor' **
********************************************************************/
template <> struct Uint_type<8>::Divisor<1> { enum { WIDTH_LOG2 = 0 }; };
template <> struct Uint_type<8>::Divisor<2> { enum { WIDTH_LOG2 = 1 }; };
template <> struct Uint_type<8>::Divisor<4> { enum { WIDTH_LOG2 = 2 }; };
template <> struct Uint_type<8>::Divisor<8> { enum { WIDTH_LOG2 = 3 }; };
template <> struct Uint_type<16>::Divisor<16> { enum { WIDTH_LOG2 = 4 }; }; template <> struct Uint_type<16>::Divisor<16> { enum { WIDTH_LOG2 = 4 }; };
template <> struct Uint_type<32>::Divisor<32> { enum { WIDTH_LOG2 = 5 }; }; template <> struct Uint_type<32>::Divisor<32> { enum { WIDTH_LOG2 = 5 }; };
template <> struct Uint_type<64>::Divisor<64> { enum { WIDTH_LOG2 = 6 }; }; template <> struct Uint_type<64>::Divisor<64> { enum { WIDTH_LOG2 = 6 }; };
@ -69,9 +80,9 @@ namespace Genode
* \param _ACCESS_WIDTH Bit width of the region * \param _ACCESS_WIDTH Bit width of the region
* *
* \detail The register can contain multiple bitfields. Bitfields * \detail The register can contain multiple bitfields. Bitfields
* that are partially exceed the register range are read and * that are partially exceed the register range are read and
* written also partially. Bitfields that are completely out * written also partially. Bitfields that are completely out
* of the register range are read as '0' and trying to * of the register range are read as '0' and trying to
* overwrite them has no effect. * overwrite them has no effect.
*/ */
template <unsigned long _ACCESS_WIDTH> template <unsigned long _ACCESS_WIDTH>
@ -87,8 +98,9 @@ namespace Genode
/** /**
* A bitregion within a register * A bitregion within a register
* *
* \param _SHIFT Bit shift of the first bit within the compound register * \param _SHIFT Bit shift of the first bit within the compound
* register
* \param _WIDTH Bit width of the region * \param _WIDTH Bit width of the region
* *
* \detail Bitfields are read and written according to their range, * \detail Bitfields are read and written according to their range,
@ -117,17 +129,20 @@ namespace Genode
typedef Register<ACCESS_WIDTH> Compound_reg; typedef Register<ACCESS_WIDTH> Compound_reg;
/** /**
* Get a register value with this bitfield set to 'value' and the rest left zero * Get a register value with this bitfield set to 'value' and the
* rest left zero
* *
* \detail Useful to combine successive access to multiple bitfields * \detail Useful to combine successive access to multiple
* into one operation * bitfields into one operation
*/ */
static inline access_t bits(access_t const value) { return (value & MASK) << SHIFT; } static inline access_t bits(access_t const value) {
return (value & MASK) << SHIFT; }
/** /**
* Get value of this bitfield from 'reg' * Get value of this bitfield from 'reg'
*/ */
static inline access_t get(access_t const reg) { return (reg >> SHIFT) & MASK; } static inline access_t get(access_t const reg) {
return (reg >> SHIFT) & MASK; }
/** /**
* Get registervalue 'reg' with this bitfield set to zero * Get registervalue 'reg' with this bitfield set to zero