genode/repos/base-hw/src/lib/hw/page_table_allocator.h

138 lines
3.4 KiB
C
Raw Normal View History

/*
* \brief Page table allocator
* \author Stefan Kalkowski
* \date 2015-06-10
*/
/*
* Copyright (C) 2015-2017 Genode Labs GmbH
*
* This file is part of the Genode OS framework, which is distributed
* under the terms of the GNU Affero General Public License version 3.
*/
#ifndef _SRC__LIB__HW__PAGE_TABLE_ALLOCATOR_H_
#define _SRC__LIB__HW__PAGE_TABLE_ALLOCATOR_H_
#include <util/bit_allocator.h>
#include <util/construct_at.h>
namespace Hw {
template <Genode::size_t TABLE_SIZE> class Page_table_allocator;
struct Out_of_tables {};
}
template <Genode::size_t TABLE_SIZE>
class Hw::Page_table_allocator
{
protected:
using addr_t = Genode::addr_t;
addr_t const _virt_addr;
addr_t const _phys_addr;
template <typename TABLE> addr_t _offset(TABLE & table) {
return (addr_t)&table - _virt_addr; }
void * _index(unsigned idx) {
return (void*)(_virt_addr + TABLE_SIZE*idx); }
virtual unsigned _alloc() = 0;
virtual void _free(unsigned idx) = 0;
public:
template <unsigned COUNT> class Array;
Page_table_allocator(addr_t virt_addr, addr_t phys_addr)
: _virt_addr(virt_addr), _phys_addr(phys_addr) { }
Follow practices suggested by "Effective C++" The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
2017-12-21 15:42:15 +01:00
virtual ~Page_table_allocator() { }
template <typename TABLE> addr_t phys_addr(TABLE & table) {
static_assert((sizeof(TABLE) == TABLE_SIZE), "unexpected size");
return _offset(table) + _phys_addr; }
template <typename TABLE> TABLE & virt_addr(addr_t phys_addr) {
static_assert((sizeof(TABLE) == TABLE_SIZE), "unexpected size");
return *(TABLE*)(_virt_addr + (phys_addr - _phys_addr)); }
template <typename TABLE> TABLE & construct() {
static_assert((sizeof(TABLE) == TABLE_SIZE), "unexpected size");
return *Genode::construct_at<TABLE>(_index(_alloc())); }
template <typename TABLE> void destruct(TABLE & table)
{
static_assert((sizeof(TABLE) == TABLE_SIZE), "unexpected size");
table.~TABLE();
_free(_offset(table) / sizeof(TABLE));
}
};
template <Genode::size_t TABLE_SIZE>
template <unsigned COUNT>
class Hw::Page_table_allocator<TABLE_SIZE>::Array
{
public:
class Allocator;
private:
struct Table { Genode::uint8_t data[TABLE_SIZE]; };
Table _tables[COUNT];
Allocator _alloc;
public:
Array() : _alloc((Table*)&_tables, (addr_t)&_tables) {}
template <typename T>
explicit Array(T phys_addr)
: _alloc(_tables, phys_addr((void*)_tables)) { }
Page_table_allocator<TABLE_SIZE> & alloc() { return _alloc; }
};
template <Genode::size_t TABLE_SIZE>
template <unsigned COUNT>
class Hw::Page_table_allocator<TABLE_SIZE>::Array<COUNT>::Allocator
: public Hw::Page_table_allocator<TABLE_SIZE>
{
private:
using Bit_allocator = Genode::Bit_allocator<COUNT>;
using Array = Page_table_allocator<TABLE_SIZE>::Array<COUNT>;
Follow practices suggested by "Effective C++" The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
2017-12-21 15:42:15 +01:00
Bit_allocator _free_tables { };
unsigned _alloc() override
{
try {
return _free_tables.alloc();
} catch (typename Bit_allocator::Out_of_indices&) {}
throw Out_of_tables();
}
void _free(unsigned idx) override { _free_tables.free(idx); }
public:
Allocator(Table * tables, addr_t phys_addr)
: Page_table_allocator((addr_t)tables, phys_addr) {}
Allocator(addr_t phys_addr, addr_t virt_addr)
: Page_table_allocator(virt_addr, phys_addr),
_free_tables(static_cast<Allocator*>(&reinterpret_cast<Array*>(virt_addr)->alloc())->_free_tables)
{
static_assert(!__is_polymorphic(Bit_allocator),
"base class needs to be non-virtual");
}
};
#endif /* _SRC__LIB__HW__PAGE_TABLE_ALLOCATOR_H_ */