c3d2/c3d2-web
c3d2
/
c3d2-web
38
3
Fork 1
Code Issues 1 Pull Requests Releases Wiki Activity

fix/broken-links #5

Merged
sandro merged 21 commits from aviac/c3d2-web:fix/broken-links into master 2023-11-07 19:27:02 +01:00
Conversation 5 Commits 21 Files Changed 22 +27 -28
aviac commented 2023-11-03 18:40:35 +01:00
Collaborator
Copy Link

Because of aviac/c3d2-web-zola#1 I just wanted to index all the existing links on the site to gain an overview over what to expect if I want to try to replicate the website.

I used LinkChecker to create the index. This resulted in a diagnostics file attached to this PR which includes some invalid links. Note that not all of those invalid links are actually strictly invalid.

Nevertheless there are some links that were fixable and I just did that here.

*Edit: Ok actually it seems like I'm not allowed to attach something or the thing just gets swallowed by the void

Because of https://gitea.c3d2.de/aviac/c3d2-web-zola/issues/1 I just wanted to index all the existing links on the site to gain an overview over what to expect if I want to try to replicate the website. I used [LinkChecker](https://linkchecker.github.io/linkchecker/) to create the index. This resulted in a diagnostics file attached to this PR which includes some invalid links. Note that not all of those invalid links are actually strictly invalid. Nevertheless there are some links that were fixable and I just did that here. *Edit: Ok actually it seems like I'm not allowed to attach something or the thing just gets swallowed by the void
aviac added 18 commits 2023-11-03 18:40:38 +01:00
sandro commented 2023-11-06 11:17:58 +01:00
Owner
Copy Link

We don't really do semantic commits since it's annoying but just keep it as is, no one really cares enough.

We don't really do semantic commits since it's annoying but just keep it as is, no one really cares enough.
👍 1
aviac closed this pull request 2023-11-06 11:18:43 +01:00
sandro reviewed 2023-11-06 11:18:53 +01:00
content/news/ta-silc.xml Outdated
@ -15,3 +15,3 @@
Internet-Chat-Protokoll. Es ist als Alternative zu anderen
Protokollen wie IRC oder Jabber-MUC anzusehen und wird vom c3d2
schon seit Jahren <link href="silc.html">verwendet</link>.
schon seit Jahren verwendet.
sandro commented 2023-11-06 11:18:53 +01:00
Owner
Copy Link

there are more https://gitea.c3d2.de/c3d2/c3d2-web/search?q=silc.html

there are more https://gitea.c3d2.de/c3d2/c3d2-web/search?q=silc.html
sandro commented 2023-11-06 11:19:42 +01:00
Owner
Copy Link

actually the link should be https://c3d2.de/news/silc.html

It seems to be that news was at some point put from / to /news/

actually the link should be https://c3d2.de/news/silc.html It seems to be that news was at some point put from / to /news/
aviac marked this conversation as resolved
aviac reopened this pull request 2023-11-06 11:19:37 +01:00
sandro reviewed 2023-11-06 11:20:49 +01:00
content/news/ds16-cfp.xml Outdated
@ -46,3 +46,3 @@
href="https://frab.cccv.de/en/DS2016/cfp/">frab</link>
</li>
<li> Kontakt/Rückfragen:<link href="datenspuren@c3d2.de">datenspuren@c3d2.de</link></li>
<li> Kontakt/Rückfragen:<a href="mailto:datenspuren@c3d2.de">datenspuren@c3d2.de</a></li>
sandro commented 2023-11-06 11:20:49 +01:00
Owner
Copy Link

Is this not being proxied through xslt? If not then this is correct.

Also two lines below there is another link tag

Is this not being proxied through xslt? If not then this is correct. Also two lines below there is another link tag
aviac marked this conversation as resolved
sandro reviewed 2023-11-06 11:22:02 +01:00
content/news/ds10-flyer.xml
@ -11,2 +11,2 @@
<p> <link href="http://datenspuren.de/dsMMX-flyer-front.png"><image title="Datenspuren 2010 - Flyer front">http://datenspuren.de/dsMMX-flyer-front_kl.png</image></link>
<link href="http://datenspuren.de/dsMMX-flyer-back.png"><image title="Datenspuren 2010 - Flyer back">http://datenspuren.de/dsMMX-flyer-back_kl.png</image></link>
<p>
<image>datenspuren/2010/dsMMX-flyer-front.png</image>
sandro commented 2023-11-06 11:22:02 +01:00
Owner
Copy Link

the links are
https://www.datenspuren.de/2010/dsMMX-flyer-front.png
https://www.datenspuren.de/2010/dsMMX-flyer-back.png

the links are https://www.datenspuren.de/2010/dsMMX-flyer-front.png https://www.datenspuren.de/2010/dsMMX-flyer-back.png
aviac commented 2023-11-06 13:23:30 +01:00
Author
Collaborator
Copy Link

Ofc I can change that if you want to.

I just want to note that:

  • it works locally this way
  • I generally thought that it would be better to use the repo-local source of truth for the images if it's available
Ofc I can change that if you want to. I just want to note that: - it works locally this way - I generally thought that it would be better to use the repo-local source of truth for the images if it's available
aviac added 2 commits 2023-11-06 13:23:43 +01:00
aviac added 1 commit 2023-11-06 17:15:07 +01:00
astro requested changes 2023-11-07 01:43:02 +01:00
astro left a comment
Owner
Copy Link

nice

nice
content/news/pentacast-47-farbmanagement.xml
@ -211,3 +211,3 @@
href="http://de.wikipedia.org/wiki/Parallelepiped">ein
spatförmiger Ausschnitt</link> aus dem XZY-Farbraum.
<image title="Screenshot Mac OS X ColorSync Utility">../images/news/pentacast-47-colorsync.png</image>
<image title="Screenshot Mac OS X ColorSync Utility">images/news/pentacast-47-colorsync.png</image>
astro commented 2023-11-07 01:41:04 +01:00
Owner
Copy Link

That's incorrect relative to /news/

That's incorrect relative to `/news/`
sandro marked this conversation as resolved
content/news/pentaradio24-20121127.xml
@ -18,3 +18,3 @@
Stelle ein paar Zuhörerstatistiken. Die Sendung lief von 21:30
bis 23:00 Uhr.
<image title="Stream-Statistiken">../images/news/pentaradio-20121127-stats.png</image>
<image title="Stream-Statistiken">images/news/pentaradio-20121127-stats.png</image>
astro commented 2023-11-07 01:42:29 +01:00
Owner
Copy Link

Drop this one, too

Drop this one, too
sandro marked this conversation as resolved
aviac commented 2023-11-07 08:53:28 +01:00
Author
Collaborator
Copy Link

I can also apply these changes if you want. Just let me mention:

If I locally generate the output via make www both of the sites link correctly to the images in the local www folder. Here's the raw generated source code of the two html files for the relevant spots.

www/news/pentaradio24-20121127.html 
    <p>
      Da es einen experimentellen Video-Stream gab, folgen an dieser
      Stelle ein paar Zuhörerstatistiken. Die Sendung lief von 21:30
      bis 23:00 Uhr.
      <img src="../images/news/pentaradio-20121127-stats.png" title="Stream-Statistiken" alt="Stream-Statistiken" class="" loading="lazy"/>
    </p>
pentacast-47-farbmanagement.html 
        <li>
			RGB ist also nur <a href="http://de.wikipedia.org/wiki/Parallelepiped">ein
				spatförmiger Ausschnitt</a> aus dem XZY-Farbraum.
			<img src="../images/news/pentacast-47-colorsync.png" title="Screenshot Mac OS X ColorSync Utility" alt="Screenshot Mac OS X ColorSync Utility" class="" loading="lazy"/>
		</li>

Ofc I don't have a clue how you actually deploy all of the results from this repo. I just thought that "if it works locally, it'll work on the remote" as well. So: Is there any special preprocessing you're doing for the deploy?

I can also apply these changes if you want. Just let me mention: If I locally generate the output via `make www` both of the sites link correctly to the images in the local `www` folder. Here's the raw generated source code of the two `html` files for the relevant spots. <details> <summary> www/news/pentaradio24-20121127.html </summary> ```html <p> Da es einen experimentellen Video-Stream gab, folgen an dieser Stelle ein paar Zuhörerstatistiken. Die Sendung lief von 21:30 bis 23:00 Uhr. <img src="../images/news/pentaradio-20121127-stats.png" title="Stream-Statistiken" alt="Stream-Statistiken" class="" loading="lazy"/> </p> ``` </details> <details> <summary> pentacast-47-farbmanagement.html </summary> ```html <li> RGB ist also nur <a href="http://de.wikipedia.org/wiki/Parallelepiped">ein spatförmiger Ausschnitt</a> aus dem XZY-Farbraum. <img src="../images/news/pentacast-47-colorsync.png" title="Screenshot Mac OS X ColorSync Utility" alt="Screenshot Mac OS X ColorSync Utility" class="" loading="lazy"/> </li> ``` </details> Ofc I don't have a clue how you actually deploy all of the results from this repo. I just thought that "if it works locally, it'll work on the remote" as well. So: Is there any special preprocessing you're doing for the deploy?
sandro commented 2023-11-07 19:26:03 +01:00
Owner
Copy Link

Yeah, those are incorrect right now

https://c3d2.de/news/pentaradio24-20121127.html
https://c3d2.de/news/images/news/pentaradio-20121127-stats.png

https://c3d2.de/news/pentacast-47-farbmanagement.html
https://c3d2.de/news/images/news/pentaradio-20121127-stats.png
Yeah, those are incorrect right now ``` https://c3d2.de/news/pentaradio24-20121127.html https://c3d2.de/news/images/news/pentaradio-20121127-stats.png https://c3d2.de/news/pentacast-47-farbmanagement.html https://c3d2.de/news/images/news/pentaradio-20121127-stats.png ```
sandro commented 2023-11-07 19:26:29 +01:00
Owner
Copy Link

We should use absolute links in the future, the ones right now are not that great

We should use absolute links in the future, the ones right now are not that great
👍 1
sandro merged commit 7259266fd1 into master 2023-11-07 19:27:02 +01:00
sandro deleted branch fix/broken-links 2023-11-07 19:27:02 +01:00
sandro commented 2023-12-03 17:17:45 +01:00
Owner
Copy Link

hmmm 🤔 attachments seem to work

hmmm 🤔 attachments seem to work
robot.png
22 KiB
robot.png
👀 1
Sign in to join this conversation.
Reviewers
No reviewers
astro
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: c3d2/c3d2-web#5
No description provided.
Delete Branch "aviac/c3d2-web:fix/broken-links"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?