The Jingle XEP states [1] that the `<reason/>` element may contain up
to one element which further qualifies the error condition:
> The <reason/> element MAY contain an element qualified by some other
> namespace that provides more detailed machine-readable information
> about the reason for the action.
The schema agrees:
> ```
> <xs:complexType name='reasonElementType'>
> <xs:sequence>
> <xs:choice>
> <!-- … omitted … -->
> </xs:choice>
> <!-- … omitted … -->
> <xs:any namespace='##other' minOccurs='0' maxOccurs='1'/>
> </xs:sequence>
> </xs:complexType>
> ```
[1]: https://xmpp.org/extensions/xep-0166.html#def-reason
The Jingle XEP says [1]:
> The <reason/> element MAY contain a <text/> element that provides
> human-readable information about the reason for the action.
It says nowhere that there may be more than one `<text/>` element in
there, or that they may be qualified by xml:lang. The schema [2] also
agrees with that:
> ```
> <xs:complexType name='reasonElementType'>
> <xs:sequence>
> <xs:choice>
> <!-- … omitted … -->
> </xs:choice>
> <xs:element name='text' type='xs:string' minOccurs='0' maxOccurs='1'/>
> <!-- … omitted … -->
> </xs:sequence>
> </xs:complexType>
> ```
[1]: https://xmpp.org/extensions/xep-0166.html#def-reason
[2]: https://xmpp.org/extensions/xep-0166.html#schema-jingle
This does not matter much because users need to replace usages of these
anyway, but it's better to have it right here to not cause additional
confusion.
This moves InnerJid into Jid and reformulates BareJid and FullJid in
terms of Jid.
Doing this has the key advantage that FullJid and BareJid can deref to
and borrow as Jid. This, in turn, has the advantage that they can be
used much more flexibly in HashMaps. However, this is (as we say in
Germany) future music; this commit only does the internal reworking.
Oh and also, it saves 20% memory on Jid objects.
Fixes#122 more thoroughly, or rather the original intent behind it.
This provides a non-copying API, which is generally favourable. The
other accessors were removed, because the intent was to provide this
"most sensible" API via the "default" (i.e. shortest, most concisely
named) functions.
This introduces a str-like type for each of these, which will allow
returning a ref instead of the copied data from various methods in
{Full,Bare}Jid.
The use of a macro ensures that all types are declared consistently.
This allows constructs like:
```rust
let residual = match Iq::try_from(stanza) {
Ok(iq) => return handle_iq(..),
Err(Error::TypeMismatch(_, _, v)) => v,
Err(other) => return handle_parse_error(..),
};
let residual = match Message::try_from(stanza) {
..
};
let residual = ..
log::warn!("unhandled object: {:?}", residual);
```
The interesting part of this is that this could be used in a loop over a
Vec<Box<dyn FnMut(Element) -> ControlFlow<SomeResult, Element>>, i.e. in
a parsing loop for a generic XML/XMPP stream.
The advantage is that the stanza.is() check runs only once (in
check_self!) and doesn't need to be duplicated outside, and it reduces
the use of magic strings.
Since Rust 1.76, and some much older nightly, there have been
improvements to the niche computation, which leads to smaller types
which can encode the same amount of data, variants, and such.
This fixes the tests on this compiler version.
