Commit Graph

11 Commits

Author SHA1 Message Date
Thomas De Schampheleire
be084204eb Config.in files: add missing dependencies to toolchain option comments
When a package A depends on config option B and toolchain option C, then
the comment that is given when C is not fulfilled should also depend on B.
For example:

config BR2_PACKAGE_A
	depends on BR2_B
	depends on BR2_LARGEFILE
	depends on BR2_WCHAR

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

This comment should actually be:

comment "A needs a toolchain w/ largefile, wchar"
	depends on BR2_B
	depends on !BR2_LARGEFILE || !BR2_WCHAR

or if possible (typically when B is a package config option declared in that
same Config.in file):

if BR2_B

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

[other config options depending on B]

endif

Otherwise, the comment would be visible even though the other dependencies
are not met.

This patch adds such missing dependencies, and changes existing such
dependencies from
  depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC
to
  depends on BR2_BASE_DEP
  depends on !BR2_TOOLCHAIN_USES_GLIBC
so that (positive) base dependencies are separate from the (negative)
toolchain dependencies. This strategy makes it easier to write such comments
(because one can simply copy the base dependency from the actual package
config option), but also avoids complex and long boolean expressions.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (untested)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-10 23:59:57 +01:00
Gustavo Zacarias
ca5639f8d0 alsamixergui: needs mmu
Because of the new fl_open_uri() function since the fltk bump using
fork().

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-10-28 17:28:28 +01:00
Thomas De Schampheleire
66bb10b7b0 Config.in files: unify comments of toolchain option dependencies
This patch lines up the comments in Config.in files that clarify which
toolchain options the package depends on.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-10-14 22:45:57 +02:00
Thomas Petazzoni
3dfc8573f6 alsamixergui: use a normal 'select' statement for the alsa-lib dependency
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-09-20 21:51:27 +02:00
Peter Korsgaard
4642701281 alsamixergui: fix alsa dependencies
Alsamixergui needs pcm and mixer support in alsa-lib.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2011-02-25 21:08:35 +01:00
Peter Korsgaard
884c7c6b99 alsamixergui: needs C++ support for fltk
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2010-07-21 21:06:13 +02:00
Peter Korsgaard
cf10280744 package/alsamixergui: fix build
And provide correct dependencies (alsa-lib).

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2009-11-30 11:25:30 +01:00
Peter Korsgaard
1620cc3e35 alsamixergui: depend on x11 support, rather than (indirectly) selecting it
Packages should depend on BR2_PACKAGE_XORG7 rather than selecting it,
because:
 - X brings in a lot of dependencies, so shouldn't get implicitly enabled
 - Select doesn't check dependencies, so build breaks if XORG dependencies
   aren't met (locale/wchar)

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2009-11-23 09:59:23 +01:00
Peter Korsgaard
26383b86d3 alsamixergui: fix long help text lines
Select fltk and fix homepage link while we're at it.
2008-08-27 20:19:34 +00:00
Peter Korsgaard
4683420c4c Kconfig: remove 'default n'
'default n' is the default, so there's no need to say it explicitly.
2008-07-17 20:01:44 +00:00
John Voltz
0c368b715f add alsamixergui and docker packages 2008-03-20 16:55:37 +00:00