From c2a7f0d6051f71f3bb9d83b574d70814339e4b95 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20Th=C3=A9baudeau?= Date: Tue, 5 Aug 2014 14:12:29 +0200 Subject: [PATCH] dhcpdump: Fix strsep() feature test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use the official _BSD_SOURCE feature test macro instead of the meaningless HAVE_STRSEP macro in order to detect the availability of strsep(). This allows toolchains supporting strsep() to use it instead of the custom implementation from dhcpdump, which also avoids the following error with some toolchains: In file included from dhcpdump.c:30:0: dhcpdump.c: At top level: strsep.c:65:23: error: register name not specified for ‘delim’ register const char *delim; ^ Signed-off-by: Benoît Thébaudeau Signed-off-by: Thomas Petazzoni --- ...hcpdump-0002-fix-strsep-feature-test.patch | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 package/dhcpdump/dhcpdump-0002-fix-strsep-feature-test.patch diff --git a/package/dhcpdump/dhcpdump-0002-fix-strsep-feature-test.patch b/package/dhcpdump/dhcpdump-0002-fix-strsep-feature-test.patch new file mode 100644 index 000000000..06bab947c --- /dev/null +++ b/package/dhcpdump/dhcpdump-0002-fix-strsep-feature-test.patch @@ -0,0 +1,27 @@ +Use the official _BSD_SOURCE feature test macro instead of the meaningless +HAVE_STRSEP macro in order to detect the availability of strsep(). + +This allows toolchains supporting strsep() to use it instead of the custom +implementation from dhcpdump, which also avoids the following error with some +toolchains: + + In file included from dhcpdump.c:30:0: + dhcpdump.c: At top level: + strsep.c:65:23: error: register name not specified for ‘delim’ + register const char *delim; + ^ + +Signed-off-by: Benoît Thébaudeau + +diff -Nrdup dhcpdump-1.8.orig/dhcpdump.c dhcpdump-1.8/dhcpdump.c +--- dhcpdump-1.8.orig/dhcpdump.c 2008-06-24 05:26:52.000000000 +0200 ++++ dhcpdump-1.8/dhcpdump.c 2011-05-31 19:22:15.987388498 +0200 +@@ -26,7 +26,7 @@ + #include + #include "dhcp_options.h" + +-#ifndef HAVE_STRSEP ++#ifndef _BSD_SOURCE + #include "strsep.c" + #endif +