gitolite/buildrootschalter
gitolite/buildrootschalter
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

util-linux: libblkid needs fork(), disable on !MMU

Browse Source 
The libblkid library in util-linux uses fork. While it seems
potentially possible to disable the parts of the library that use fork
(the only parts using fork are parts related to LVM and Device Mapper,
which are said to be legacy as they are replaced by sysfs based
scanning, instead of having to fork to run a separate process).

However, since libblkid is used by:

 - e2fsprogs, which uses lots of fork all over the place
 - udev, which most likely will also need fork

There is not much point in making libblkid fork-less. As a
consequence, this commit makes util-linux/libblkid unavailable on
non-MMU architectures, and propagates the relevant dependency to the
reverse dependencies of libblkid.

This fixes the e2fsprogs build failure seen on Blackfin. The failure
was due to a configure test of e2fsprogs which was trying to link a
small test program against libblkid, which failed because there was an
undefined reference to fork() in the libblkid code.

Fixes:

  http://autobuild.buildroot.net/results/ee2c1568d16ac040011dd4d6d8b543ff9e9e2622/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Thomas Petazzoni 2014-02-23 23:58:07 +01:00 committed by Peter Korsgaard
parent 848c5b9480
commit a8da3cd61a
5 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package/cryptsetup/Config.in
View File

@ -6,7 +6,7 @@ config BR2_PACKAGE_CRYPTSETUP
select BR2_PACKAGE_E2FSPROGS select BR2_PACKAGE_E2FSPROGS
select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
depends on BR2_LARGEFILE # lvm2, util-linux depends on BR2_LARGEFILE # lvm2, util-linux
depends on BR2_USE_MMU # lvm2 depends on BR2_USE_MMU # lvm2, e2fsprogs
depends on !BR2_PREFER_STATIC_LIB # lvm2 depends on !BR2_PREFER_STATIC_LIB # lvm2
depends on BR2_USE_WCHAR # util-linux depends on BR2_USE_WCHAR # util-linux
help help

1
package/e2fsprogs/Config.in
View File

@ -3,6 +3,7 @@ config BR2_PACKAGE_E2FSPROGS
bool "e2fsprogs" bool "e2fsprogs"
depends on BR2_LARGEFILE depends on BR2_LARGEFILE
depends on BR2_USE_WCHAR # util-linux depends on BR2_USE_WCHAR # util-linux
depends on BR2_USE_MMU # util-linux/libblkid
select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX
select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
select BR2_PACKAGE_UTIL_LINUX_LIBUUID select BR2_PACKAGE_UTIL_LINUX_LIBUUID

1
package/udev/Config.in
View File

@ -5,6 +5,7 @@ config BR2_PACKAGE_UDEV
depends on BR2_LARGEFILE # util-linux depends on BR2_LARGEFILE # util-linux
depends on BR2_USE_WCHAR # util-linux depends on BR2_USE_WCHAR # util-linux
depends on !BR2_PREFER_STATIC_LIB # kmod depends on !BR2_PREFER_STATIC_LIB # kmod
depends on BR2_USE_MMU # util-linux/libblkid
select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX
select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
select BR2_PACKAGE_KMOD select BR2_PACKAGE_KMOD

2
package/util-linux/Config.in
View File

@ -14,6 +14,7 @@ if BR2_PACKAGE_UTIL_LINUX
config BR2_PACKAGE_UTIL_LINUX_LIBBLKID config BR2_PACKAGE_UTIL_LINUX_LIBBLKID
select BR2_PACKAGE_UTIL_LINUX_LIBUUID select BR2_PACKAGE_UTIL_LINUX_LIBUUID
depends on BR2_USE_MMU # fork
bool "libblkid" bool "libblkid"
help help
Install libblkid. Install libblkid.
@ -22,6 +23,7 @@ config BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
select BR2_PACKAGE_UTIL_LINUX_LIBBLKID select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
# libc lacks UTIME_NOW & UTIME_COMMIT # libc lacks UTIME_NOW & UTIME_COMMIT
depends on !(BR2_microblazeel || BR2_microblazebe) depends on !(BR2_microblazeel || BR2_microblazebe)
depends on BR2_USE_MMU # util-linux/libblkid
bool "libmount" bool "libmount"
help help
Install libmount. Install libmount.

1
system/Config.in
View File

@ -127,6 +127,7 @@ config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
depends on BR2_LARGEFILE # udev depends on BR2_LARGEFILE # udev
depends on BR2_USE_WCHAR # udev depends on BR2_USE_WCHAR # udev
depends on !BR2_PREFER_STATIC_LIB # udev -> kmod depends on !BR2_PREFER_STATIC_LIB # udev -> kmod
depends on BR2_USE_MMU # udev -> util-linux/libblkid
select BR2_PACKAGE_UDEV select BR2_PACKAGE_UDEV
comment "udev needs a toolchain w/ largefile, wchar" comment "udev needs a toolchain w/ largefile, wchar"