From 1727e89e9a6076ac81235a9377b749606e23d110 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sun, 6 Jan 2013 05:22:47 +0000 Subject: [PATCH] perf: add kernel version checks perf is only available since kernel 2.6.31, so if we can't find tools/perf/Makefile, error out and tell the user about this. perf without libelf can only be built since kernel 3.7, so error out and tell the user about this if he's trying to build perf from a < 3.7 kernel without libelf. Unfortunately, those tests can only be build-time checks as we either need to know the real kernel version (i.e, using LINUX_VERSION would not be correct as it can be a Git commit ID, or Git tag), or have access to the kernel sources themselves. So we can't prevent those invalid situations at the configuration, we can only nicely tell the user at build time. Signed-off-by: Thomas Petazzoni Signed-off-by: Peter Korsgaard --- package/perf/perf.mk | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/package/perf/perf.mk b/package/perf/perf.mk index eed30a289..4356f5db5 100644 --- a/package/perf/perf.mk +++ b/package/perf/perf.mk @@ -28,6 +28,18 @@ else endif define PERF_BUILD_CMDS + $(Q)if test ! -f $(LINUX_DIR)/tools/perf/Makefile ; then \ + echo "Your kernel version is too old and does not have the perf tool." ; \ + echo "At least kernel 2.6.31 must be used." ; \ + exit 1 ; \ + fi + $(Q)if test "$(BR2_PACKAGE_ELFUTILS)" = "" ; then \ + if ! grep -q NO_LIBELF $(LINUX_DIR)/tools/perf/Makefile ; then \ + echo "The perf tool in your kernel cannot be built without libelf." ; \ + echo "Either upgrade your kernel to >= 3.7, or enable the elfutils package." ; \ + exit 1 ; \ + fi \ + fi $(MAKE) -C $(LINUX_DIR)/tools/perf \ $(PERF_MAKE_FLAGS) O=$(@D) endef