Browse Source

PULL_REQUEST_TEMPLATE.md: Ask for closure size impact

nixos-19.03
Eelco Dolstra 3 years ago
parent
commit
bf1c28e978
No account linked to committer's email address
1 changed files with 1 additions and 0 deletions
  1. 1
    0
      .github/PULL_REQUEST_TEMPLATE.md

+ 1
- 0
.github/PULL_REQUEST_TEMPLATE.md View File

@@ -13,6 +13,7 @@
13 13
 - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
14 14
 - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
15 15
 - [ ] Tested execution of all binary files (usually in `./result/bin/`)
16
+- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
16 17
 - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
17 18
 
18 19
 ---

Loading…
Cancel
Save