eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
81 lines
2.1 KiB
C++
81 lines
2.1 KiB
C++
/*
|
|
* \brief Fiasco.OC utilities
|
|
* \author Christian Helmuth
|
|
* \author Stefan Kalkowski
|
|
* \date 2006-04-11
|
|
*
|
|
* Is very practical now, but please keep the errors of the l4util pkg in mind.
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2006-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__INCLUDE__UTIL_H_
|
|
#define _CORE__INCLUDE__UTIL_H_
|
|
|
|
/* Genode includes */
|
|
#include <base/stdint.h>
|
|
#include <base/log.h>
|
|
#include <rm_session/rm_session.h>
|
|
#include <util/touch.h>
|
|
|
|
/* base-internal includes */
|
|
#include <base/internal/page_size.h>
|
|
|
|
/* Fiasco includes */
|
|
namespace Fiasco {
|
|
#include <l4/sys/types.h>
|
|
#include <l4/sys/ktrace.h>
|
|
}
|
|
|
|
namespace Genode {
|
|
|
|
inline void panic(const char *s)
|
|
{
|
|
raw(s);
|
|
raw("> panic <");
|
|
while (1) ;
|
|
}
|
|
|
|
inline void touch_ro(const void *addr, unsigned size)
|
|
{
|
|
using namespace Fiasco;
|
|
unsigned char const volatile *bptr;
|
|
unsigned char const *eptr;
|
|
|
|
bptr = (unsigned char const volatile *)(((Genode::addr_t)addr) & L4_PAGEMASK);
|
|
eptr = (unsigned char const *)(((Genode::addr_t)addr + size - 1) & L4_PAGEMASK);
|
|
for ( ; bptr <= eptr; bptr += L4_PAGESIZE)
|
|
touch_read(bptr);
|
|
}
|
|
|
|
inline void touch_rw(const void *addr, unsigned size)
|
|
{
|
|
using namespace Fiasco;
|
|
unsigned char volatile *bptr;
|
|
unsigned char const *eptr;
|
|
|
|
bptr = (unsigned char volatile *)(((Genode::addr_t)addr) & L4_PAGEMASK);
|
|
eptr = (unsigned char const *)(((Genode::addr_t)addr + size - 1) & L4_PAGEMASK);
|
|
for (; bptr <= eptr; bptr += L4_PAGESIZE)
|
|
touch_read_write(bptr);
|
|
}
|
|
|
|
inline addr_t trunc_page(addr_t addr) { return Fiasco::l4_trunc_page(addr); }
|
|
inline addr_t round_page(addr_t addr) { return Fiasco::l4_round_page(addr); }
|
|
|
|
constexpr size_t get_super_page_size() { return L4_SUPERPAGESIZE; }
|
|
constexpr size_t get_super_page_size_log2() { return L4_LOG2_SUPERPAGESIZE; }
|
|
|
|
inline addr_t map_src_addr(addr_t core_local_addr, addr_t) {
|
|
return core_local_addr; }
|
|
|
|
inline size_t constrain_map_size_log2(size_t size_log2) { return size_log2; }
|
|
}
|
|
|
|
#endif /* _CORE__INCLUDE__UTIL_H_ */
|