eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
68 lines
1.7 KiB
C++
68 lines
1.7 KiB
C++
/*
|
|
* \brief Fiasco.OC-specific core implementation of IRQ sessions
|
|
* \author Christian Helmuth
|
|
* \author Stefan Kalkowski
|
|
* \author Sebastian Sumpf
|
|
* \date 2007-09-13
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2007-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__INCLUDE__IRQ_OBJECT_H_
|
|
#define _CORE__INCLUDE__IRQ_OBJECT_H_
|
|
|
|
/* Genode includes */
|
|
#include <irq_session/irq_session.h>
|
|
#include <cap_index.h>
|
|
|
|
namespace Genode { class Irq_object; }
|
|
|
|
|
|
class Genode::Irq_object
|
|
{
|
|
private:
|
|
|
|
/*
|
|
* Noncopyable
|
|
*/
|
|
Irq_object(Irq_object const &);
|
|
Irq_object &operator = (Irq_object const &);
|
|
|
|
Cap_index *_cap;
|
|
Irq_session::Trigger _trigger; /* interrupt trigger */
|
|
Irq_session::Polarity _polarity; /* interrupt polarity */
|
|
|
|
unsigned _irq;
|
|
Genode::addr_t _msi_addr;
|
|
Genode::addr_t _msi_data;
|
|
|
|
Signal_context_capability _sig_cap { };
|
|
|
|
Fiasco::l4_cap_idx_t _capability() const { return _cap->kcap(); }
|
|
|
|
public:
|
|
|
|
Irq_object();
|
|
~Irq_object();
|
|
|
|
Irq_session::Trigger trigger() const { return _trigger; }
|
|
Irq_session::Polarity polarity() const { return _polarity; }
|
|
|
|
Genode::addr_t msi_address() const { return _msi_addr; }
|
|
Genode::addr_t msi_value() const { return _msi_data; }
|
|
|
|
void sigh(Genode::Signal_context_capability cap) { _sig_cap = cap; }
|
|
void notify() { Genode::Signal_transmitter(_sig_cap).submit(1); }
|
|
|
|
bool associate(unsigned irq, bool msi, Irq_session::Trigger,
|
|
Irq_session::Polarity);
|
|
void ack_irq();
|
|
};
|
|
|
|
#endif /* _CORE__INCLUDE__IRQ_OBJECT_H_ */
|