b585583ec7
Destroying an object within the scope of a lambda/functor executed in the object pool's apply function leads potentially to memory corruption. Within the scope the corresponding object is locked and unlocked when leaving the scope. Therefore, it is illegal to free the object's memory meanwhile. This commit eliminates several places in core that destroyed wrongly in the object pool's scope. Fix #1713
126 lines
3.4 KiB
C++
126 lines
3.4 KiB
C++
/*
|
|
* \brief Implementation of the SIGNAL service on the HW-core
|
|
* \author Martin Stein
|
|
* \date 2012-05-05
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2012-2013 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU General Public License version 2.
|
|
*/
|
|
|
|
/* Genode includes */
|
|
#include <base/printf.h>
|
|
#include <unmanaged_singleton.h>
|
|
|
|
/* base-hw includes */
|
|
#include <kernel/core_interface.h>
|
|
|
|
/* core includes */
|
|
#include <signal_session_component.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
Signal_session_component::Receiver::Receiver()
|
|
: Kernel_object<Kernel::Signal_receiver>(true),
|
|
Signal_session_component::Receiver::Pool::Entry(Kernel_object<Kernel::Signal_receiver>::_cap) { }
|
|
|
|
|
|
Signal_session_component::Context::Context(Signal_session_component::Receiver &r,
|
|
unsigned const imprint)
|
|
: Kernel_object<Kernel::Signal_context>(true, r.kernel_object(), imprint),
|
|
Signal_session_component::Context::Pool::Entry(Kernel_object<Kernel::Signal_context>::_cap) { }
|
|
|
|
|
|
Signal_receiver_capability Signal_session_component::alloc_receiver()
|
|
{
|
|
try {
|
|
Receiver * r = new (_receivers_slab) Receiver();
|
|
_receivers.insert(r);
|
|
return reinterpret_cap_cast<Signal_receiver>(r->cap());
|
|
} catch (Allocator::Out_of_memory&) {
|
|
PERR("failed to allocate signal-receiver resources");
|
|
throw Out_of_metadata();
|
|
}
|
|
return reinterpret_cap_cast<Signal_receiver>(Untyped_capability());
|
|
}
|
|
|
|
|
|
void Signal_session_component::free_receiver(Signal_receiver_capability cap)
|
|
{
|
|
/* look up ressource info */
|
|
Receiver * receiver;
|
|
auto lambda = [&] (Receiver *r) {
|
|
receiver = r;
|
|
if (!receiver) {
|
|
PERR("unknown signal receiver");
|
|
throw Kill_receiver_failed();
|
|
}
|
|
/* release resources */
|
|
_receivers.remove(receiver);
|
|
};
|
|
_receivers.apply(cap, lambda);
|
|
destroy(&_receivers_slab, receiver);
|
|
}
|
|
|
|
|
|
Signal_context_capability
|
|
Signal_session_component::alloc_context(Signal_receiver_capability src,
|
|
unsigned const imprint)
|
|
{
|
|
/* look up ressource info */
|
|
auto lambda = [&] (Receiver *r) {
|
|
if (!r) {
|
|
PERR("unknown signal receiver");
|
|
throw Create_context_failed();
|
|
}
|
|
|
|
try {
|
|
Context * c = new (_contexts_slab) Context(*r, imprint);
|
|
_contexts.insert(c);
|
|
return reinterpret_cap_cast<Signal_context>(c->cap());
|
|
} catch (Allocator::Out_of_memory&) {
|
|
PERR("failed to allocate signal-context resources");
|
|
throw Out_of_metadata();
|
|
}
|
|
return reinterpret_cap_cast<Signal_context>(Untyped_capability());
|
|
};
|
|
return _receivers.apply(src, lambda);
|
|
}
|
|
|
|
|
|
void Signal_session_component::free_context(Signal_context_capability cap)
|
|
{
|
|
/* look up ressource info */
|
|
Context * context;
|
|
auto lambda = [&] (Context *c) {
|
|
context = c;
|
|
if (!context) {
|
|
PERR("unknown signal context");
|
|
throw Kill_context_failed();
|
|
}
|
|
/* release resources */
|
|
_contexts.remove(context);
|
|
};
|
|
_contexts.apply(cap, lambda);
|
|
destroy(&_contexts_slab, context);
|
|
}
|
|
|
|
|
|
Signal_session_component::Signal_session_component(Allocator * const allocator,
|
|
size_t const quota)
|
|
: _allocator(allocator, quota), _receivers_slab(&_allocator),
|
|
_contexts_slab(&_allocator) { }
|
|
|
|
|
|
Signal_session_component::~Signal_session_component()
|
|
{
|
|
_contexts.remove_all([this] (Context * c) {
|
|
destroy(&_contexts_slab, c);});
|
|
_receivers.remove_all([this] (Receiver * r) {
|
|
destroy(&_receivers_slab, r);});
|
|
}
|