6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
65 lines
1.9 KiB
C++
65 lines
1.9 KiB
C++
/*
|
|
* \brief Export RAM dataspace as shared memory object (dummy)
|
|
* \author Martin Stein
|
|
* \author Stefan Kalkowski
|
|
* \date 2012-02-12
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2012-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* Genode includes */
|
|
#include <base/log.h>
|
|
|
|
/* core includes */
|
|
#include <ram_dataspace_factory.h>
|
|
#include <platform.h>
|
|
#include <map_local.h>
|
|
|
|
using namespace Genode;
|
|
|
|
void Ram_dataspace_factory::_export_ram_ds(Dataspace_component &) { }
|
|
void Ram_dataspace_factory::_revoke_ram_ds(Dataspace_component &) { }
|
|
|
|
void Ram_dataspace_factory::_clear_ds (Dataspace_component &ds)
|
|
{
|
|
size_t page_rounded_size = (ds.size() + get_page_size() - 1) & get_page_mask();
|
|
|
|
/* allocate range in core's virtual address space */
|
|
void *virt_addr;
|
|
if (!platform().region_alloc().alloc(page_rounded_size, &virt_addr)) {
|
|
error("could not allocate virtual address range in core of size ",
|
|
page_rounded_size);
|
|
return;
|
|
}
|
|
|
|
/* map the dataspace's physical pages to corresponding virtual addresses */
|
|
size_t num_pages = page_rounded_size >> get_page_size_log2();
|
|
if (!map_local(ds.phys_addr(), (addr_t)virt_addr, num_pages)) {
|
|
error("core-local memory mapping failed");
|
|
return;
|
|
}
|
|
|
|
/* clear dataspace */
|
|
memset(virt_addr, 0, page_rounded_size);
|
|
|
|
/* uncached dataspaces need to be flushed from the data cache */
|
|
if (ds.cacheability() != CACHED)
|
|
Kernel::update_data_region((addr_t)virt_addr, page_rounded_size);
|
|
|
|
/* invalidate the dataspace memory from instruction cache */
|
|
Kernel::update_instr_region((addr_t)virt_addr, page_rounded_size);
|
|
|
|
/* unmap dataspace from core */
|
|
if (!unmap_local((addr_t)virt_addr, num_pages))
|
|
error("could not unmap core-local address range at ", virt_addr);
|
|
|
|
/* free core's virtual address space */
|
|
platform().region_alloc().free(virt_addr, page_rounded_size);
|
|
}
|
|
|