genode/repos/base-linux/src/core/platform_thread.cc
Norman Feske 6b289a1423 base/core: use references instead of pointers
This patch replaces the former prominent use of pointers by references
wherever feasible. This has the following benefits:

* The contract between caller and callee becomes more obvious. When
  passing a reference, the contract says that the argument cannot be
  a null pointer. The caller is responsible to ensure that. Therefore,
  the use of reference eliminates the need to add defensive null-pointer
  checks at the callee site, which sometimes merely exist to be on the
  safe side. The bottom line is that the code becomes easier to follow.

* Reference members must be initialized via an object initializer,
  which promotes a programming style that avoids intermediate object-
  construction states. Within core, there are still a few pointers
  as member variables left though. E.g., caused by the late association
  of 'Platform_thread' objects with their 'Platform_pd' objects.

* If no pointers are present as member variables, we don't need to
  manually provide declarations of a private copy constructor and
  an assignment operator to avoid -Weffc++ errors "class ... has
  pointer data members [-Werror=effc++]".

This patch also changes a few system bindings on NOVA and Fiasco.OC,
e.g., the return value of the global 'cap_map' accessor has become a
reference. Hence, the patch touches a few places outside of core.

Fixes #3135
2019-02-12 10:33:13 +01:00

133 lines
2.5 KiB
C++

/*
* \brief Linux-specific platform thread implementation
* \author Norman Feske
* \date 2007-10-15
*/
/*
* Copyright (C) 2007-2017 Genode Labs GmbH
*
* This file is part of the Genode OS framework, which is distributed
* under the terms of the GNU Affero General Public License version 3.
*/
/* Genode includes */
#include <util/token.h>
#include <util/misc_math.h>
#include <base/log.h>
/* local includes */
#include "platform_thread.h"
#include "server_socket_pair.h"
using namespace Genode;
typedef Token<Scanner_policy_identifier_with_underline> Tid_token;
/*******************************
** Platform_thread::Registry **
*******************************/
void Platform_thread::Registry::insert(Platform_thread *thread)
{
Lock::Guard guard(_lock);
_list.insert(thread);
}
void Platform_thread::Registry::remove(Platform_thread *thread)
{
Lock::Guard guard(_lock);
_list.remove(thread);
}
void Platform_thread::Registry::submit_exception(unsigned long pid)
{
Lock::Guard guard(_lock);
/* traverse list to find 'Platform_thread' with matching PID */
for (Platform_thread *curr = _list.first(); curr; curr = curr->next()) {
if (curr->_tid == pid) {
Signal_context_capability sigh = curr->_pager._sigh;
if (sigh.valid())
Signal_transmitter(sigh).submit();
return;
}
}
}
Platform_thread::Registry &Platform_thread::_registry()
{
static Platform_thread::Registry registry;
return registry;
}
/*********************
** Platform_thread **
*********************/
Platform_thread::Platform_thread(size_t, const char *name, unsigned,
Affinity::Location, addr_t)
{
strncpy(_name, name, min(sizeof(_name), strlen(name) + 1));
_registry().insert(this);
}
Platform_thread::~Platform_thread()
{
ep_sd_registry().disassociate(_socket_pair.client_sd);
if (_socket_pair.client_sd)
lx_close(_socket_pair.client_sd);
if (_socket_pair.server_sd)
lx_close(_socket_pair.server_sd);
_registry().remove(this);
}
void Platform_thread::cancel_blocking()
{
lx_tgkill(_pid, _tid, LX_SIGUSR1);
}
void Platform_thread::pause()
{
warning(__func__, "not implemented");
}
void Platform_thread::resume()
{
warning(__func__, "not implemented");
}
int Platform_thread::client_sd()
{
/* construct socket pair on first call */
if (_socket_pair.client_sd == -1)
_socket_pair = create_server_socket_pair(_tid);
return _socket_pair.client_sd;
}
int Platform_thread::server_sd()
{
client_sd();
return _socket_pair.server_sd;
}