6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
62 lines
1.2 KiB
C++
62 lines
1.2 KiB
C++
/*
|
|
* \brief Implementation of Thread API interface on top of Platform_thread
|
|
* \author Norman Feske
|
|
* \date 2006-05-03
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2006-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* Genode includes */
|
|
#include <base/thread.h>
|
|
#include <base/sleep.h>
|
|
|
|
/* base-internal includes */
|
|
#include <base/internal/stack.h>
|
|
|
|
/* core includes */
|
|
#include <platform.h>
|
|
#include <core_env.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
void Thread::_thread_start()
|
|
{
|
|
Thread::myself()->_thread_bootstrap();
|
|
Thread::myself()->entry();
|
|
Thread::myself()->_join_lock.unlock();
|
|
sleep_forever();
|
|
}
|
|
|
|
|
|
void Thread::start()
|
|
{
|
|
/* create and start platform thread */
|
|
native_thread().pt = new (platform_specific().thread_slab())
|
|
Platform_thread(_stack->name().string());
|
|
|
|
platform_specific().core_pd().bind_thread(*native_thread().pt);
|
|
|
|
native_thread().pt->start((void *)_thread_start, stack_top());
|
|
}
|
|
|
|
|
|
void Thread::cancel_blocking()
|
|
{
|
|
/*
|
|
* Within core, we never need to unblock threads
|
|
*/
|
|
}
|
|
|
|
|
|
void Thread::_deinit_platform_thread()
|
|
{
|
|
/* destruct platform thread */
|
|
destroy(platform_specific().thread_slab(), native_thread().pt);
|
|
}
|