This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
53 lines
986 B
C++
53 lines
986 B
C++
/*
|
|
* \brief Capability IDs allocation service
|
|
* \author Stefan Kalkowski
|
|
* \date 2012-02-22
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2012-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__INCLUDE__CAP_ID_ALLOC_H_
|
|
#define _CORE__INCLUDE__CAP_ID_ALLOC_H_
|
|
|
|
/* Genode includes */
|
|
#include <base/allocator_avl.h>
|
|
#include <base/exception.h>
|
|
#include <base/lock.h>
|
|
#include <synced_range_allocator.h>
|
|
|
|
namespace Genode {
|
|
|
|
class Cap_id_allocator
|
|
{
|
|
private:
|
|
|
|
enum {
|
|
CAP_ID_RANGE = ~0UL,
|
|
CAP_ID_MASK = ~3UL,
|
|
CAP_ID_NUM_MAX = CAP_ID_MASK >> 2,
|
|
CAP_ID_OFFSET = 1 << 2
|
|
};
|
|
|
|
Synced_range_allocator<Allocator_avl> _id_alloc;
|
|
|
|
Lock _lock { };
|
|
|
|
public:
|
|
|
|
class Out_of_ids : Exception {};
|
|
|
|
|
|
Cap_id_allocator(Allocator &);
|
|
|
|
unsigned long alloc();
|
|
void free(unsigned long id);
|
|
};
|
|
}
|
|
|
|
#endif /* _CORE__INCLUDE__CAP_ID_ALLOC_H_ */
|