6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
54 lines
1.1 KiB
C++
54 lines
1.1 KiB
C++
/*
|
|
* \brief RPC capability factory
|
|
* \author Norman Feske
|
|
* \date 2016-01-19
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <rpc_cap_factory.h>
|
|
#include <platform.h>
|
|
|
|
/* base-internal include */
|
|
#include <core_capability_space.h>
|
|
#include <base/internal/capability_space_tpl.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
static unsigned unique_id_cnt;
|
|
|
|
|
|
Native_capability Rpc_cap_factory::_alloc(Rpc_cap_factory &,
|
|
Native_capability ep)
|
|
{
|
|
if (!ep.valid()) {
|
|
warning("Invalid entrypoint capability");
|
|
return Native_capability();
|
|
}
|
|
|
|
Rpc_obj_key const rpc_obj_key(++unique_id_cnt);
|
|
|
|
/* combine thread ID of 'ep' with new unique ID */
|
|
Capability_space::Ipc_cap_data cap_data =
|
|
Capability_space::ipc_cap_data(ep);
|
|
|
|
return Capability_space::import(cap_data.dst, rpc_obj_key);
|
|
}
|
|
|
|
|
|
Native_capability Rpc_cap_factory::alloc(Native_capability ep)
|
|
{
|
|
return Rpc_cap_factory::_alloc(*this, ep);
|
|
}
|
|
|
|
|
|
void Rpc_cap_factory::free(Native_capability) { }
|
|
|