6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
114 lines
1.9 KiB
C++
114 lines
1.9 KiB
C++
/*
|
|
* \brief Core implementation of the CPU thread interface
|
|
* \author Norman Feske
|
|
* \date 2016-05-10
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <cpu_thread_component.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
void Cpu_thread_component::_update_exception_sigh()
|
|
{
|
|
Signal_context_capability sigh = _thread_sigh.valid()
|
|
? _thread_sigh : _session_sigh;
|
|
|
|
_platform_thread.pager().exception_handler(sigh);
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::quota(size_t quota)
|
|
{
|
|
_platform_thread.quota(quota);
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::session_exception_sigh(Signal_context_capability sigh)
|
|
{
|
|
_session_sigh = sigh;
|
|
_update_exception_sigh();
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::start(addr_t ip, addr_t sp)
|
|
{
|
|
_platform_thread.start((void *)ip, (void *)sp);
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::pause()
|
|
{
|
|
_platform_thread.pause();
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::single_step(bool enabled)
|
|
{
|
|
_platform_thread.single_step(enabled);
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::resume()
|
|
{
|
|
_platform_thread.resume();
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::cancel_blocking()
|
|
{
|
|
_platform_thread.cancel_blocking();
|
|
}
|
|
|
|
|
|
Thread_state Cpu_thread_component::state()
|
|
{
|
|
return _platform_thread.state();
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::state(Thread_state const &state)
|
|
{
|
|
_platform_thread.state(state);
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::exception_sigh(Signal_context_capability sigh)
|
|
{
|
|
_thread_sigh = sigh;
|
|
_update_exception_sigh();
|
|
}
|
|
|
|
|
|
void Cpu_thread_component::affinity(Affinity::Location location)
|
|
{
|
|
_platform_thread.affinity(location);
|
|
}
|
|
|
|
|
|
unsigned Cpu_thread_component::trace_control_index()
|
|
{
|
|
return _trace_control_slot.index;
|
|
}
|
|
|
|
|
|
Dataspace_capability Cpu_thread_component::trace_buffer()
|
|
{
|
|
return _trace_source.buffer();
|
|
}
|
|
|
|
|
|
Dataspace_capability Cpu_thread_component::trace_policy()
|
|
{
|
|
return _trace_source.policy();
|
|
}
|
|
|