eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
141 lines
3.7 KiB
C++
141 lines
3.7 KiB
C++
/*
|
|
* \brief NOVA-specific signal-delivery mechanism
|
|
* \author Norman Feske
|
|
* \date 2016-01-04
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__INCLUDE__SIGNAL_BROKER_H_
|
|
#define _CORE__INCLUDE__SIGNAL_BROKER_H_
|
|
|
|
/* Genode includes */
|
|
#include <base/tslab.h>
|
|
|
|
/* NOVA includes */
|
|
#include <nova/capability_space.h>
|
|
|
|
/* core-local includes */
|
|
#include <platform.h>
|
|
#include <signal_source_component.h>
|
|
#include <signal_source/capability.h>
|
|
#include <signal_context_slab.h>
|
|
|
|
namespace Genode { class Signal_broker; }
|
|
|
|
|
|
class Genode::Signal_broker
|
|
{
|
|
private:
|
|
|
|
Allocator &_md_alloc;
|
|
Rpc_entrypoint &_source_ep;
|
|
Object_pool<Signal_context_component> _obj_pool { };
|
|
Rpc_entrypoint &_context_ep;
|
|
Signal_source_component _source;
|
|
Signal_source_capability _source_cap;
|
|
Signal_context_slab _context_slab { _md_alloc };
|
|
|
|
public:
|
|
|
|
class Invalid_signal_source : public Exception { };
|
|
|
|
Signal_broker(Allocator &md_alloc,
|
|
Rpc_entrypoint &source_ep,
|
|
Rpc_entrypoint &context_ep)
|
|
:
|
|
_md_alloc(md_alloc),
|
|
_source_ep(source_ep),
|
|
_context_ep(context_ep),
|
|
_source(&_context_ep),
|
|
_source_cap(_source_ep.manage(&_source))
|
|
{ }
|
|
|
|
~Signal_broker()
|
|
{
|
|
/* remove source from entrypoint */
|
|
_source_ep.dissolve(&_source);
|
|
|
|
/* free all signal contexts */
|
|
while (Signal_context_component *r = _context_slab.any_signal_context())
|
|
free_context(reinterpret_cap_cast<Signal_context>(r->cap()));
|
|
}
|
|
|
|
Signal_source_capability alloc_signal_source() { return _source_cap; }
|
|
|
|
void free_signal_source(Signal_source_capability) { }
|
|
|
|
/*
|
|
* \throw Allocator::Out_of_memory
|
|
*/
|
|
Signal_context_capability
|
|
alloc_context(Signal_source_capability, unsigned long imprint)
|
|
{
|
|
/*
|
|
* XXX For now, we ignore the signal-source argument as we
|
|
* create only a single receiver for each PD.
|
|
*/
|
|
|
|
Native_capability sm = _source.blocking_semaphore();
|
|
|
|
if (!sm.valid()) {
|
|
warning("signal receiver sm is not valid");
|
|
for (;;);
|
|
return Signal_context_capability();
|
|
}
|
|
|
|
Native_capability si = Capability_space::import(cap_map()->insert());
|
|
Signal_context_capability cap = reinterpret_cap_cast<Signal_context>(si);
|
|
|
|
uint8_t res = Nova::create_si(cap.local_name(),
|
|
platform_specific()->core_pd_sel(),
|
|
imprint, sm.local_name());
|
|
if (res != Nova::NOVA_OK) {
|
|
warning("creating signal failed - error ", res);
|
|
return Signal_context_capability();
|
|
}
|
|
|
|
/* the _contexts_slab may throw Allocator::Out_of_memory */
|
|
_obj_pool.insert(new (&_context_slab) Signal_context_component(cap));
|
|
|
|
/* return unique capability for the signal context */
|
|
return cap;
|
|
}
|
|
|
|
void free_context(Signal_context_capability context_cap)
|
|
{
|
|
Signal_context_component *context;
|
|
auto lambda = [&] (Signal_context_component *c) {
|
|
context = c;
|
|
if (context) _obj_pool.remove(context);
|
|
};
|
|
_obj_pool.apply(context_cap, lambda);
|
|
|
|
if (!context) {
|
|
warning(this, " - specified signal-context capability has wrong type ",
|
|
Hex(context_cap.local_name()));
|
|
return;
|
|
}
|
|
destroy(&_context_slab, context);
|
|
|
|
Nova::revoke(Nova::Obj_crd(context_cap.local_name(), 0));
|
|
cap_map()->remove(context_cap.local_name(), 0);
|
|
}
|
|
|
|
void submit(Signal_context_capability, unsigned)
|
|
{
|
|
/*
|
|
* On NOVA, signals are submitted directly to the kernel, not
|
|
* by using core as a proxy.
|
|
*/
|
|
ASSERT_NEVER_CALLED;
|
|
}
|
|
};
|
|
|
|
#endif /* _CORE__INCLUDE__SIGNAL_BROKER_H_ */
|