6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
99 lines
2.1 KiB
C++
99 lines
2.1 KiB
C++
/*
|
|
* \brief RPC capability factory
|
|
* \author Norman Feske
|
|
* \date 2016-01-19
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core-local includes */
|
|
#include <rpc_cap_factory.h>
|
|
#include <platform.h>
|
|
|
|
/* NOVA includes */
|
|
#include <nova/capability_space.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
Native_capability Rpc_cap_factory::alloc(Native_capability ep, addr_t entry, addr_t mtd)
|
|
{
|
|
addr_t const pt_sel = cap_map().insert();
|
|
addr_t const pd_sel = platform_specific().core_pd_sel();
|
|
addr_t const ec_sel = ep.local_name();
|
|
|
|
using namespace Nova;
|
|
|
|
Lock::Guard guard(_lock);
|
|
|
|
/* create cap object */
|
|
Cap_object * pt_cap = new (&_slab) Cap_object(pt_sel);
|
|
if (!pt_cap)
|
|
return Native_capability();
|
|
|
|
_list.insert(pt_cap);
|
|
|
|
/* create portal */
|
|
uint8_t const res = create_pt(pt_sel, pd_sel, ec_sel, Mtd(mtd), entry);
|
|
if (res == NOVA_OK)
|
|
return Capability_space::import(pt_sel);
|
|
|
|
error("cap alloc - "
|
|
"cap=", Hex(ec_sel), ":", Hex(ep.local_name()), " "
|
|
"entry=", Hex(entry), " "
|
|
"mtd=", Hex(mtd), " "
|
|
"xpt=", Hex(pt_sel), " "
|
|
"res=", res);
|
|
|
|
_list.remove(pt_cap);
|
|
destroy(&_slab, pt_cap);
|
|
|
|
/* cleanup unused selectors */
|
|
cap_map().remove(pt_sel, 0, false);
|
|
|
|
return Native_capability();
|
|
}
|
|
|
|
|
|
void Rpc_cap_factory::free(Native_capability cap)
|
|
{
|
|
if (!cap.valid()) return;
|
|
|
|
Lock::Guard guard(_lock);
|
|
|
|
for (Cap_object *obj = _list.first(); obj ; obj = obj->next()) {
|
|
if (cap.local_name() == (long)obj->_cap_sel) {
|
|
Nova::revoke(Nova::Obj_crd(obj->_cap_sel, 0));
|
|
cap_map().remove(obj->_cap_sel, 0, false);
|
|
|
|
_list.remove(obj);
|
|
destroy(&_slab, obj);
|
|
return;
|
|
}
|
|
}
|
|
warning("attempt to free invalid cap object");
|
|
}
|
|
|
|
|
|
Rpc_cap_factory::Rpc_cap_factory(Allocator &md_alloc)
|
|
: _slab(md_alloc, _initial_sb) { }
|
|
|
|
|
|
Rpc_cap_factory::~Rpc_cap_factory()
|
|
{
|
|
Lock::Guard guard(_lock);
|
|
|
|
for (Cap_object *obj; (obj = _list.first()); ) {
|
|
Nova::revoke(Nova::Obj_crd(obj->_cap_sel, 0));
|
|
cap_map().remove(obj->_cap_sel, 0, false);
|
|
|
|
_list.remove(obj);
|
|
destroy(&_slab, obj);
|
|
}
|
|
}
|