6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
37 lines
933 B
C++
37 lines
933 B
C++
/*
|
|
* \brief Core implementation of the ROM session interface
|
|
* \author Norman Feske
|
|
* \date 2006-07-06
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2006-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#include <util/arg_string.h>
|
|
#include <rom_session_component.h>
|
|
#include <root/root.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
Rom_session_component::Rom_session_component(Rom_fs &rom_fs,
|
|
Rpc_entrypoint &ds_ep,
|
|
const char *args)
|
|
:
|
|
_rom_module(&_find_rom(rom_fs, args)),
|
|
_ds(_rom_module ? _rom_module->size : 0,
|
|
_rom_module ? _rom_module->addr : 0, CACHED, false, 0),
|
|
_ds_ep(ds_ep),
|
|
_ds_cap(static_cap_cast<Rom_dataspace>(_ds_ep.manage(&_ds)))
|
|
{ }
|
|
|
|
|
|
Rom_session_component::~Rom_session_component()
|
|
{
|
|
_ds_ep.dissolve(&_ds);
|
|
}
|