6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
83 lines
2.0 KiB
C++
83 lines
2.0 KiB
C++
/*
|
|
* \brief Core-specific instance of the ROM session interface
|
|
* \author Norman Feske
|
|
* \date 2006-07-06
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2006-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__INCLUDE__ROM_SESSION_COMPONENT_H_
|
|
#define _CORE__INCLUDE__ROM_SESSION_COMPONENT_H_
|
|
|
|
#include <rom_fs.h>
|
|
#include <base/rpc_server.h>
|
|
#include <dataspace_component.h>
|
|
#include <rom_session/rom_session.h>
|
|
#include <base/session_label.h>
|
|
|
|
namespace Genode {
|
|
|
|
class Rom_session_component : public Rpc_object<Rom_session>
|
|
{
|
|
private:
|
|
|
|
Rom_module const * const _rom_module = nullptr;
|
|
Dataspace_component _ds;
|
|
Rpc_entrypoint &_ds_ep;
|
|
Rom_dataspace_capability _ds_cap;
|
|
|
|
Rom_module const &_find_rom(Rom_fs &rom_fs, const char *args)
|
|
{
|
|
/* extract label */
|
|
Session_label const label = label_from_args(args);
|
|
|
|
/* find ROM module for trailing label element */
|
|
Rom_module const * rom = rom_fs.find(label.last_element().string());
|
|
if (rom)
|
|
return *rom;
|
|
|
|
throw Service_denied();
|
|
}
|
|
|
|
/*
|
|
* Noncopyable
|
|
*/
|
|
Rom_session_component(Rom_session_component const &);
|
|
Rom_session_component &operator = (Rom_session_component const &);
|
|
|
|
public:
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* \param rom_fs ROM filesystem
|
|
* \param ds_ep entry point to manage the dataspace
|
|
* corresponding the rom session
|
|
* \param args session-construction arguments
|
|
*/
|
|
Rom_session_component(Rom_fs &rom_fs,
|
|
Rpc_entrypoint &ds_ep,
|
|
const char *args);
|
|
|
|
/**
|
|
* Destructor
|
|
*/
|
|
~Rom_session_component();
|
|
|
|
|
|
/***************************
|
|
** Rom session interface **
|
|
***************************/
|
|
|
|
Rom_dataspace_capability dataspace() override { return _ds_cap; }
|
|
void sigh(Signal_context_capability) override { }
|
|
};
|
|
}
|
|
|
|
#endif /* _CORE__INCLUDE__ROM_SESSION_COMPONENT_H_ */
|