6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
61 lines
1.4 KiB
C++
61 lines
1.4 KiB
C++
/*
|
|
* \brief Fiasco.OC specific capability mapping.
|
|
* \author Stefan Kalkowski
|
|
* \date 2012-02-22
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2012-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__INCLUDE__CAP_MAPPING_H_
|
|
#define _CORE__INCLUDE__CAP_MAPPING_H_
|
|
|
|
/* core includes */
|
|
#include <cap_index.h>
|
|
#include <util/noncopyable.h>
|
|
|
|
namespace Genode {
|
|
|
|
/**
|
|
* A Cap_mapping embodies a capability of core, and its mapped
|
|
* copy in another protection domain.
|
|
*/
|
|
class Cap_mapping : Noncopyable
|
|
{
|
|
private:
|
|
|
|
/**
|
|
* Helper function for construction purposes.
|
|
*
|
|
* Allocates a new capability id and Core_cap_index and inserts
|
|
* it in the Cap_map.
|
|
*
|
|
* \return pointer to newly constructed Core_cap_index object
|
|
*/
|
|
inline Core_cap_index *_get_cap();
|
|
|
|
public:
|
|
|
|
Native_capability local; /* reference to cap that is mapped */
|
|
Fiasco::l4_cap_idx_t remote; /* index in cap-space of the other pd */
|
|
|
|
Cap_mapping(bool alloc=false,
|
|
Fiasco::l4_cap_idx_t r = Fiasco::L4_INVALID_CAP);
|
|
Cap_mapping(Native_capability cap,
|
|
Fiasco::l4_cap_idx_t r = Fiasco::L4_INVALID_CAP);
|
|
|
|
/**
|
|
* Map the cap in local to corresponding task.
|
|
*
|
|
* \param task capability of task to map to
|
|
*/
|
|
void map(Fiasco::l4_cap_idx_t task);
|
|
};
|
|
}
|
|
|
|
#endif /* _CORE__INCLUDE__CAP_MAPPING_H_ */
|