eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
123 lines
2.6 KiB
C++
123 lines
2.6 KiB
C++
/*
|
|
* \brief RPC capability factory
|
|
* \author Norman Feske
|
|
* \date 2016-01-19
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__RPC_CAP_FACTORY_H_
|
|
#define _CORE__RPC_CAP_FACTORY_H_
|
|
|
|
/* Genode includes */
|
|
#include <util/list.h>
|
|
#include <util/construct_at.h>
|
|
#include <base/lock.h>
|
|
#include <base/tslab.h>
|
|
#include <base/capability.h>
|
|
#include <base/log.h>
|
|
|
|
/* core-local includes */
|
|
#include <object.h>
|
|
#include <kernel/thread.h>
|
|
|
|
/* base-internal includes */
|
|
#include <base/internal/capability_space.h>
|
|
|
|
namespace Genode { class Rpc_cap_factory; }
|
|
|
|
|
|
class Genode::Rpc_cap_factory
|
|
{
|
|
private:
|
|
|
|
/**
|
|
* Kernel object placeholder held in a list
|
|
*/
|
|
struct Kobject : List<Kobject>::Element
|
|
{
|
|
using Identity = Kernel::Core_object_identity<Kernel::Thread>;
|
|
|
|
Native_capability cap { };
|
|
|
|
uint8_t data[sizeof(Identity)]
|
|
__attribute__((aligned(sizeof(addr_t))));
|
|
};
|
|
|
|
using Slab = Tslab<Kobject, get_page_size()>;
|
|
|
|
uint8_t _initial_slab_block[get_page_size()];
|
|
Slab _slab;
|
|
List<Kobject> _list { };
|
|
Lock _lock { };
|
|
|
|
public:
|
|
|
|
Rpc_cap_factory(Allocator &md_alloc)
|
|
:
|
|
_slab(&md_alloc, &_initial_slab_block)
|
|
{ }
|
|
|
|
~Rpc_cap_factory()
|
|
{
|
|
Lock::Guard guard(_lock);
|
|
|
|
while (Kobject * obj = _list.first()) {
|
|
Kernel::delete_obj(obj->data);
|
|
_list.remove(obj);
|
|
destroy(&_slab, obj);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Allocate RPC capability
|
|
*
|
|
* \throw Allocator::Out_of_memory
|
|
*/
|
|
Native_capability alloc(Native_capability ep)
|
|
{
|
|
Lock::Guard guard(_lock);
|
|
|
|
/* allocate kernel object */
|
|
Kobject * obj;
|
|
if (!_slab.alloc(sizeof(Kobject), (void**)&obj))
|
|
throw Allocator::Out_of_memory();
|
|
construct_at<Kobject>(obj);
|
|
|
|
/* create kernel object via syscall */
|
|
Kernel::capid_t capid = Kernel::new_obj(obj->data, Capability_space::capid(ep));
|
|
obj->cap = Capability_space::import(capid);
|
|
if (!obj->cap.valid()) {
|
|
raw("Invalid entrypoint ", (addr_t)Capability_space::capid(ep),
|
|
" for allocating a capability!");
|
|
destroy(&_slab, obj);
|
|
return Native_capability();
|
|
}
|
|
|
|
/* store it in the list and return result */
|
|
_list.insert(obj);
|
|
return obj->cap;
|
|
}
|
|
|
|
void free(Native_capability cap)
|
|
{
|
|
Lock::Guard guard(_lock);
|
|
|
|
for (Kobject * obj = _list.first(); obj; obj = obj->next()) {
|
|
if (obj->cap.data() == cap.data()) {
|
|
Kernel::delete_obj(obj->data);
|
|
_list.remove(obj);
|
|
destroy(&_slab, obj);
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
#endif /* _CORE__RPC_CAP_FACTORY_H_ */
|