6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
72 lines
1.7 KiB
C++
72 lines
1.7 KiB
C++
/*
|
|
* \brief RM- and pager implementations specific for base-hw and core
|
|
* \author Martin Stein
|
|
* \author Stefan Kalkowski
|
|
* \date 2012-02-12
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2012-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <pager.h>
|
|
#include <platform_pd.h>
|
|
#include <platform_thread.h>
|
|
#include <translation_table.h>
|
|
|
|
/* base-internal includes */
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
/**********************
|
|
** Pager_entrypoint **
|
|
**********************/
|
|
|
|
void Pager_entrypoint::entry()
|
|
{
|
|
Untyped_capability cap;
|
|
|
|
while (1)
|
|
{
|
|
if (cap.valid()) Kernel::ack_signal(Capability_space::capid(cap));
|
|
|
|
/* receive fault */
|
|
if (Kernel::await_signal(Capability_space::capid(_cap))) continue;
|
|
|
|
Pager_object *po = *(Pager_object**)Thread::myself()->utcb()->data();
|
|
cap = po->cap();
|
|
|
|
if (!po) continue;
|
|
|
|
/* fetch fault data */
|
|
Platform_thread * const pt = (Platform_thread *)po->badge();
|
|
if (!pt) {
|
|
Genode::warning("failed to get platform thread of faulter");
|
|
continue;
|
|
}
|
|
|
|
_fault = pt->fault_info();
|
|
|
|
/* try to resolve fault directly via local region managers */
|
|
if (po->pager(*this)) continue;
|
|
|
|
/* apply mapping that was determined by the local region managers */
|
|
{
|
|
Locked_ptr<Address_space> locked_ptr(pt->address_space());
|
|
if (!locked_ptr.valid()) continue;
|
|
|
|
Hw::Address_space * as = static_cast<Hw::Address_space*>(&*locked_ptr);
|
|
as->insert_translation(_mapping.virt(), _mapping.phys(),
|
|
_mapping.size(), _mapping.flags());
|
|
}
|
|
|
|
/* let pager object go back to no-fault state */
|
|
po->wake_up();
|
|
}
|
|
}
|