6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
79 lines
1.8 KiB
C++
79 lines
1.8 KiB
C++
/*
|
|
* \brief Backend for IRQ sessions served by core
|
|
* \author Martin Stein
|
|
* \date 2013-10-29
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2013-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__IRQ_SESSION_COMPONENT_H_
|
|
#define _CORE__IRQ_SESSION_COMPONENT_H_
|
|
|
|
/* Genode includes */
|
|
#include <base/rpc_server.h>
|
|
#include <util/list.h>
|
|
#include <irq_session/capability.h>
|
|
|
|
#include <kernel/irq.h>
|
|
|
|
namespace Genode { class Irq_session_component; }
|
|
|
|
|
|
class Genode::Irq_session_component : public Rpc_object<Irq_session>,
|
|
private List<Irq_session_component>::Element
|
|
{
|
|
private:
|
|
|
|
friend class List<Irq_session_component>;
|
|
|
|
unsigned _irq_number;
|
|
Range_allocator &_irq_alloc;
|
|
Genode::uint8_t _kernel_object[sizeof(Kernel::User_irq)];
|
|
bool _is_msi;
|
|
addr_t _address, _value;
|
|
|
|
Signal_context_capability _sig_cap { };
|
|
|
|
unsigned _find_irq_number(const char * const args);
|
|
|
|
public:
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* \param irq_alloc platform-dependent IRQ allocator
|
|
* \param args session construction arguments
|
|
*/
|
|
Irq_session_component(Range_allocator &irq_alloc,
|
|
const char *args);
|
|
|
|
/**
|
|
* Destructor
|
|
*/
|
|
~Irq_session_component();
|
|
|
|
/***************************
|
|
** Irq session interface **
|
|
***************************/
|
|
|
|
void ack_irq() override;
|
|
void sigh(Signal_context_capability) override;
|
|
|
|
Info info() override
|
|
{
|
|
if (!_is_msi)
|
|
return { .type = Info::Type::INVALID, .address = 0, .value = 0 };
|
|
|
|
return { .type = Info::Type::MSI,
|
|
.address = _address,
|
|
.value = _value };
|
|
}
|
|
};
|
|
|
|
#endif /* _CORE__IRQ_SESSION_COMPONENT_H_ */
|