6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
45 lines
1007 B
C++
45 lines
1007 B
C++
/*
|
|
* \brief Core-specific back end of the RPC entrypoint
|
|
* \author Norman Feske
|
|
* \date 2016-01-19
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* Genode includes */
|
|
#include <base/rpc_server.h>
|
|
|
|
/* core-local includes */
|
|
#include <platform_generic.h>
|
|
#include <rpc_cap_factory.h>
|
|
#include <imprint_badge.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
static Rpc_cap_factory &rpc_cap_factory()
|
|
{
|
|
static Rpc_cap_factory inst(platform().core_mem_alloc());
|
|
return inst;
|
|
}
|
|
|
|
|
|
Native_capability Rpc_entrypoint::_alloc_rpc_cap(Pd_session &, Native_capability ep,
|
|
addr_t entry)
|
|
{
|
|
Native_capability cap = rpc_cap_factory().alloc(ep, entry, 0);
|
|
imprint_badge(cap.local_name(), cap.local_name());
|
|
return cap;
|
|
}
|
|
|
|
|
|
void Rpc_entrypoint::_free_rpc_cap(Pd_session &, Native_capability cap)
|
|
{
|
|
rpc_cap_factory().free(cap);
|
|
}
|