eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
|
||
|---|---|---|
| .. | ||
| main.cc | ||
| README | ||
| target.mk | ||
This component obtains the information about the existing trace subjects from core's "TRACE" service and delivers a report to a "Report" server. The report, in turn, can be used by top-like applications to present the consumed execution time per thread. Configuration ------------- The interval of report generation can be defined via the 'period_ms' attribute of the '<config>' node. The value is specified in milliseconds. The level of detail of the generated reports can be influenced by the '<report>' sub node of the configuration. The following example shows the default values. ! <config period_ms="5000" > ! <report activity="no" affinity="no"/> ! </config> When setting 'activity' to "yes", the report contains an '<activity>' sub node for each subject. The sub node has the two attributes 'total' and 'recent'. The 'recent' value represents the execution time consumed in the last period. When setting 'affinity' to "yes", the report contains an '<affinity>' sub node for each subject. The sub node shows the thread's physical CPU affinity, expressed via the 'xpos' and 'ypos' attributes.