6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
38 lines
928 B
C++
38 lines
928 B
C++
/*
|
|
* \brief Default implementation of the ROM modules initialization
|
|
* \author Martin Stein
|
|
* \date 2017-08-17
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <boot_modules.h>
|
|
#include <platform.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
void Platform::_init_rom_modules()
|
|
{
|
|
/* add boot modules to ROM FS */
|
|
Boot_modules_header *header = &_boot_modules_headers_begin;
|
|
for (; header < &_boot_modules_headers_end; header++) {
|
|
|
|
if (!header->size) {
|
|
warning("ignore zero-sized boot module '",
|
|
Cstring((char const *)header->name), "'");
|
|
continue;
|
|
}
|
|
Rom_module &rom_module = *new (core_mem_alloc())
|
|
Rom_module(_rom_module_phys(header->base), header->size,
|
|
(char const *)header->name);
|
|
_rom_fs.insert(&rom_module);
|
|
}
|
|
}
|