eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
122 lines
2.9 KiB
C++
122 lines
2.9 KiB
C++
/*
|
|
* \brief Framebuffer sub session as part of the nitpicker session
|
|
* \author Norman Feske
|
|
* \date 2017-11-16
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2006-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _FRAMEBUFFER_SESSION_COMPONENT_H_
|
|
#define _FRAMEBUFFER_SESSION_COMPONENT_H_
|
|
|
|
/* local includes */
|
|
#include "buffer.h"
|
|
|
|
namespace Framebuffer {
|
|
|
|
using namespace Nitpicker;
|
|
using Nitpicker::Rect;
|
|
using Nitpicker::Point;
|
|
using Nitpicker::Area;
|
|
|
|
class Session_component;
|
|
}
|
|
|
|
|
|
class Framebuffer::Session_component : public Rpc_object<Session>
|
|
{
|
|
private:
|
|
|
|
/*
|
|
* Noncopyable
|
|
*/
|
|
Session_component(Session_component const &);
|
|
Session_component &operator = (Session_component const &);
|
|
|
|
Buffer *_buffer = 0;
|
|
View_stack &_view_stack;
|
|
Nitpicker::Session_component &_session;
|
|
Framebuffer::Session &_framebuffer;
|
|
Buffer_provider &_buffer_provider;
|
|
Signal_context_capability _mode_sigh { };
|
|
Signal_context_capability _sync_sigh { };
|
|
Framebuffer::Mode _mode { };
|
|
bool _alpha = false;
|
|
|
|
public:
|
|
|
|
/**
|
|
* Constructor
|
|
*/
|
|
Session_component(View_stack &view_stack,
|
|
Nitpicker::Session_component &session,
|
|
Framebuffer::Session &framebuffer,
|
|
Buffer_provider &buffer_provider)
|
|
:
|
|
_view_stack(view_stack),
|
|
_session(session),
|
|
_framebuffer(framebuffer),
|
|
_buffer_provider(buffer_provider)
|
|
{ }
|
|
|
|
/**
|
|
* Change virtual framebuffer mode
|
|
*
|
|
* Called by Nitpicker::Session_component when re-dimensioning the
|
|
* buffer.
|
|
*
|
|
* The new mode does not immediately become active. The client can
|
|
* keep using an already obtained framebuffer dataspace. However,
|
|
* we inform the client about the mode change via a signal. If the
|
|
* client calls 'dataspace' the next time, the new mode becomes
|
|
* effective.
|
|
*/
|
|
void notify_mode_change(Framebuffer::Mode mode, bool alpha)
|
|
{
|
|
_mode = mode;
|
|
_alpha = alpha;
|
|
|
|
if (_mode_sigh.valid())
|
|
Signal_transmitter(_mode_sigh).submit();
|
|
}
|
|
|
|
void submit_sync()
|
|
{
|
|
if (_sync_sigh.valid())
|
|
Signal_transmitter(_sync_sigh).submit();
|
|
}
|
|
|
|
|
|
/************************************
|
|
** Framebuffer::Session interface **
|
|
************************************/
|
|
|
|
Dataspace_capability dataspace() override
|
|
{
|
|
_buffer = _buffer_provider.realloc_buffer(_mode, _alpha);
|
|
|
|
return _buffer ? _buffer->ds_cap() : Ram_dataspace_capability();
|
|
}
|
|
|
|
Mode mode() const override { return _mode; }
|
|
|
|
void mode_sigh(Signal_context_capability sigh) override
|
|
{
|
|
_mode_sigh = sigh;
|
|
}
|
|
|
|
void sync_sigh(Signal_context_capability sigh) override
|
|
{
|
|
_sync_sigh = sigh;
|
|
}
|
|
|
|
void refresh(int x, int y, int w, int h) override;
|
|
};
|
|
|
|
#endif /* _FRAMEBUFFER_SESSION_COMPONENT_H_ */
|