6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
48 lines
1.2 KiB
C++
48 lines
1.2 KiB
C++
/*
|
|
* \brief Fiasco.OC-specific implementation of the IO_MEM session interface
|
|
* \author Christian Helmuth
|
|
* \author Stefan Kalkowski
|
|
* \date 2006-08-28
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2006-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <platform.h>
|
|
#include <util.h>
|
|
#include <io_mem_session_component.h>
|
|
#include <map_local.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
void Io_mem_session_component::_unmap_local(addr_t base, size_t)
|
|
{
|
|
platform().region_alloc().free(reinterpret_cast<void *>(base));
|
|
}
|
|
|
|
|
|
addr_t Io_mem_session_component::_map_local(addr_t base, size_t size)
|
|
{
|
|
/* align large I/O dataspaces on a super-page boundary within core */
|
|
size_t alignment = (size >= get_super_page_size()) ? get_super_page_size_log2()
|
|
: get_page_size_log2();
|
|
|
|
/* find appropriate region for mapping */
|
|
void *local_base = 0;
|
|
if (platform().region_alloc().alloc_aligned(size, &local_base, alignment).error())
|
|
return 0;
|
|
|
|
if (!map_local_io(base, (addr_t)local_base, size >> get_page_size_log2())) {
|
|
error("map_local_io failed");
|
|
return 0;
|
|
}
|
|
|
|
return (addr_t)local_base;
|
|
}
|