6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
57 lines
1.1 KiB
C++
57 lines
1.1 KiB
C++
/*
|
|
* \brief Dataspace component
|
|
* \date 2006-09-18
|
|
* \author Christian Helmuth
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2006-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <dataspace_component.h>
|
|
#include <region_map_component.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
void Dataspace_component::attached_to(Rm_region ®ion)
|
|
{
|
|
Lock::Guard lock_guard(_lock);
|
|
_regions.insert(®ion);
|
|
}
|
|
|
|
|
|
void Dataspace_component::detached_from(Rm_region ®ion)
|
|
{
|
|
Lock::Guard lock_guard(_lock);
|
|
_regions.remove(®ion);
|
|
}
|
|
|
|
void Dataspace_component::detach_from_rm_sessions()
|
|
{
|
|
_lock.lock();
|
|
|
|
/* remove from all regions */
|
|
while (Rm_region *r = _regions.first()) {
|
|
|
|
/*
|
|
* The 'detach' function calls 'Dataspace_component::detached_from'
|
|
* and thereby removes the current region from the '_regions' list.
|
|
*/
|
|
_lock.unlock();
|
|
r->rm().detach((void *)r->base());
|
|
_lock.lock();
|
|
}
|
|
|
|
_lock.unlock();
|
|
}
|
|
|
|
Dataspace_component::~Dataspace_component()
|
|
{
|
|
detach_from_rm_sessions();
|
|
}
|