eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
108 lines
2.0 KiB
C++
108 lines
2.0 KiB
C++
/*
|
|
* \brief A timer manages a continuous time and timeouts on it
|
|
* \author Martin Stein
|
|
* \date 2016-03-23
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _CORE__KERNEL__TIMER_H_
|
|
#define _CORE__KERNEL__TIMER_H_
|
|
|
|
/* base-hw includes */
|
|
#include <kernel/types.h>
|
|
|
|
/* Genode includes */
|
|
#include <util/list.h>
|
|
|
|
/* Core includes */
|
|
#include <timer_driver.h>
|
|
|
|
namespace Kernel
|
|
{
|
|
class Timeout;
|
|
class Timer;
|
|
}
|
|
|
|
/**
|
|
* A timeout causes a kernel pass and the call of a timeout specific handle
|
|
*/
|
|
class Kernel::Timeout : Genode::List<Timeout>::Element
|
|
{
|
|
friend class Timer;
|
|
friend class Genode::List<Timeout>;
|
|
|
|
private:
|
|
|
|
bool _listed = false;
|
|
time_t _start = 0;
|
|
time_t _end = 0;
|
|
bool _end_period = false;
|
|
|
|
public:
|
|
|
|
/**
|
|
* Callback handle
|
|
*/
|
|
virtual void timeout_triggered() { }
|
|
|
|
virtual ~Timeout() { }
|
|
};
|
|
|
|
/**
|
|
* A timer manages a continuous time and timeouts on it
|
|
*/
|
|
class Kernel::Timer
|
|
{
|
|
private:
|
|
|
|
using Driver = Timer_driver;
|
|
|
|
unsigned const _cpu_id;
|
|
Driver _driver;
|
|
time_t _time = 0;
|
|
bool _time_period = false;
|
|
Genode::List<Timeout> _timeout_list[2];
|
|
time_t _last_timeout_duration = 0;
|
|
|
|
bool _time_overflow(time_t const duration) const;
|
|
|
|
void _start_one_shot(time_t const ticks);
|
|
|
|
time_t _ticks_to_us(time_t const ticks) const;
|
|
|
|
time_t _value();
|
|
|
|
time_t _max_value() const;
|
|
|
|
public:
|
|
|
|
Timer(unsigned cpu_id);
|
|
|
|
void schedule_timeout();
|
|
|
|
time_t update_time();
|
|
void process_timeouts();
|
|
|
|
void set_timeout(Timeout * const timeout, time_t const duration);
|
|
|
|
time_t us_to_ticks(time_t const us) const;
|
|
|
|
time_t timeout_age_us(Timeout const * const timeout) const;
|
|
|
|
time_t timeout_max_us() const;
|
|
|
|
unsigned interrupt_id() const;
|
|
|
|
static void init_cpu_local();
|
|
|
|
time_t time() const { return _time; }
|
|
};
|
|
|
|
#endif /* _CORE__KERNEL__TIMER_H_ */
|