6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
73 lines
1.2 KiB
C++
73 lines
1.2 KiB
C++
/*
|
|
* \brief Capability lifetime management
|
|
* \author Norman Feske
|
|
* \date 2015-05-06
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2015-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* Fiasco includes */
|
|
namespace Fiasco {
|
|
#include <l4/sys/types.h>
|
|
}
|
|
|
|
/* base-internal includes */
|
|
#include <base/internal/cap_map.h>
|
|
#include <base/internal/capability_data.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
Native_capability::Native_capability() { }
|
|
|
|
|
|
void Native_capability::_inc()
|
|
{
|
|
if (_data)
|
|
_data->inc();
|
|
}
|
|
|
|
|
|
void Native_capability::_dec()
|
|
{
|
|
if (_data && !_data->dec())
|
|
cap_map().remove(_data);
|
|
}
|
|
|
|
|
|
long Native_capability::local_name() const
|
|
{
|
|
return _data ? _data->id() : 0;
|
|
}
|
|
|
|
|
|
bool Native_capability::valid() const
|
|
{
|
|
return (_data != 0) && _data->valid();
|
|
}
|
|
|
|
|
|
Native_capability::Raw Native_capability::raw() const
|
|
{
|
|
return { (unsigned long)local_name(), 0, 0, 0 };
|
|
}
|
|
|
|
|
|
void Native_capability::print(Genode::Output &out) const
|
|
{
|
|
using Genode::print;
|
|
|
|
print(out, "cap<");
|
|
if (_data) {
|
|
print(out, "kcap=", Hex(_data->kcap()), ",key=", (unsigned)_data->id());
|
|
} else {
|
|
print(out, "invalid");
|
|
}
|
|
print(out, ">");
|
|
}
|