eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository.
To adapt existing components to fix violations of the best practices
suggested by "Effective C++" as reported by the -Weffc++ compiler
argument. The changes follow the patterns outlined below:
* A class with virtual functions can no longer publicly inherit base
classed without a vtable. The inherited object may either be moved
to a member variable, or inherited privately. The latter would be
used for classes that inherit 'List::Element' or 'Avl_node'. In order
to enable the 'List' and 'Avl_tree' to access the meta data, the
'List' must become a friend.
* Instead of adding a virtual destructor to abstract base classes,
we inherit the new 'Interface' class, which contains a virtual
destructor. This way, single-line abstract base classes can stay
as compact as they are now. The 'Interface' utility resides in
base/include/util/interface.h.
* With the new warnings enabled, all member variables must be explicitly
initialized. Basic types may be initialized with '='. All other types
are initialized with braces '{ ... }' or as class initializers. If
basic types and non-basic types appear in a row, it is nice to only
use the brace syntax (also for basic types) and align the braces.
* If a class contains pointers as members, it must now also provide a
copy constructor and assignment operator. In the most cases, one
would make them private, effectively disallowing the objects to be
copied. Unfortunately, this warning cannot be fixed be inheriting
our existing 'Noncopyable' class (the compiler fails to detect that
the inheriting class cannot be copied and still gives the error).
For now, we have to manually add declarations for both the copy
constructor and assignment operator as private class members. Those
declarations should be prepended with a comment like this:
/*
* Noncopyable
*/
Thread(Thread const &);
Thread &operator = (Thread const &);
In the future, we should revisit these places and try to replace
the pointers with references. In the presence of at least one
reference member, the compiler would no longer implicitly generate
a copy constructor. So we could remove the manual declaration.
Issue #465
145 lines
4.0 KiB
C++
145 lines
4.0 KiB
C++
/*
|
|
* \brief Support code for the thread API
|
|
* \author Norman Feske
|
|
* \author Stefan Kalkowski
|
|
* \date 2010-01-13
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2010-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* Genode includes */
|
|
#include <region_map/region_map.h>
|
|
#include <base/ram_allocator.h>
|
|
#include <base/log.h>
|
|
#include <base/synced_allocator.h>
|
|
#include <base/thread.h>
|
|
|
|
/* local includes */
|
|
#include <platform.h>
|
|
#include <map_local.h>
|
|
#include <dataspace_component.h>
|
|
#include <untyped_memory.h>
|
|
|
|
/* base-internal includes */
|
|
#include <base/internal/stack_area.h>
|
|
#include <base/internal/globals.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
/**
|
|
* Region-manager session for allocating stacks
|
|
*
|
|
* This class corresponds to the managed dataspace that is normally used for
|
|
* organizing stacks with the stack area. In contrast to the ordinary
|
|
* implementation, core's version does not split between allocation of memory
|
|
* and virtual memory management. Due to the missing availability of "real"
|
|
* dataspaces and capabilities refering to it without having an entrypoint in
|
|
* place, the allocation of a dataspace has no effect, but the attachment of
|
|
* the thereby "empty" dataspace is doing both: allocation and attachment.
|
|
*/
|
|
class Stack_area_region_map : public Region_map
|
|
{
|
|
private:
|
|
|
|
using Ds_slab = Synced_allocator<Tslab<Dataspace_component,
|
|
get_page_size()> >;
|
|
|
|
Ds_slab _ds_slab { platform()->core_mem_alloc() };
|
|
|
|
public:
|
|
|
|
/**
|
|
* Allocate and attach on-the-fly backing store to the stack area
|
|
*/
|
|
Local_addr attach(Dataspace_capability, size_t size, off_t,
|
|
bool, Local_addr local_addr, bool) override
|
|
{
|
|
size = round_page(size);
|
|
|
|
/* allocate physical memory */
|
|
Range_allocator &phys_alloc = *platform_specific()->ram_alloc();
|
|
size_t const num_pages = size >> get_page_size_log2();
|
|
addr_t const phys = Untyped_memory::alloc_pages(phys_alloc, num_pages);
|
|
Untyped_memory::convert_to_page_frames(phys, num_pages);
|
|
|
|
Dataspace_component *ds = new (&_ds_slab)
|
|
Dataspace_component(size, 0, phys, CACHED, true, 0);
|
|
if (!ds) {
|
|
error(__func__, ": dataspace for core stack does not exist");
|
|
return (addr_t)0;
|
|
}
|
|
|
|
addr_t const core_local_addr =
|
|
stack_area_virtual_base() + (addr_t)local_addr;
|
|
|
|
if (!map_local(ds->phys_addr(), core_local_addr,
|
|
ds->size() >> get_page_size_log2())) {
|
|
error(__func__, ": could not map phys ", Hex(ds->phys_addr()), " "
|
|
"at local ", Hex(core_local_addr));
|
|
return (addr_t)0;
|
|
}
|
|
|
|
ds->assign_core_local_addr((void*)core_local_addr);
|
|
|
|
return local_addr;
|
|
}
|
|
|
|
void detach(Local_addr local_addr) override
|
|
{
|
|
using Genode::addr_t;
|
|
|
|
if ((addr_t)local_addr >= stack_area_virtual_size())
|
|
return;
|
|
|
|
addr_t const detach = stack_area_virtual_base() + (addr_t)local_addr;
|
|
addr_t const stack = stack_virtual_size();
|
|
addr_t const pages = ((detach & ~(stack - 1)) + stack - detach)
|
|
>> get_page_size_log2();
|
|
|
|
unmap_local(detach, pages);
|
|
|
|
/* XXX missing XXX */
|
|
warning(__PRETTY_FUNCTION__, ": not implemented");
|
|
}
|
|
|
|
void fault_handler(Signal_context_capability) override { }
|
|
|
|
State state() override { return State(); }
|
|
|
|
Dataspace_capability dataspace() override { return Dataspace_capability(); }
|
|
};
|
|
|
|
|
|
struct Stack_area_ram_allocator : Ram_allocator
|
|
{
|
|
Ram_dataspace_capability alloc(size_t, Cache_attribute) override {
|
|
return reinterpret_cap_cast<Ram_dataspace>(Native_capability()); }
|
|
|
|
void free(Ram_dataspace_capability) override {
|
|
warning(__func__, " not implemented"); }
|
|
|
|
size_t dataspace_size(Ram_dataspace_capability) const override { return 0; }
|
|
};
|
|
|
|
|
|
namespace Genode {
|
|
|
|
Region_map *env_stack_area_region_map;
|
|
Ram_allocator *env_stack_area_ram_allocator;
|
|
|
|
void init_stack_area()
|
|
{
|
|
static Stack_area_region_map rm_inst;
|
|
env_stack_area_region_map = &rm_inst;
|
|
|
|
static Stack_area_ram_allocator ram_inst;
|
|
env_stack_area_ram_allocator = &ram_inst;
|
|
}
|
|
}
|