6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
77 lines
2.1 KiB
C++
77 lines
2.1 KiB
C++
/*
|
|
* \brief hw-specific implementation of core-local RM session
|
|
* \author Norman Feske
|
|
* \author Stefan Kalkowski
|
|
* \date 2014-02-26
|
|
*
|
|
* Taken from OKL4-specific imlementation
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2014-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* core includes */
|
|
#include <platform.h>
|
|
#include <core_region_map.h>
|
|
#include <map_local.h>
|
|
#include <util.h>
|
|
#include <base/heap.h>
|
|
|
|
using namespace Genode;
|
|
|
|
Region_map::Local_addr
|
|
Core_region_map::attach(Dataspace_capability ds_cap, size_t size,
|
|
off_t offset, bool use_local_addr,
|
|
Region_map::Local_addr, bool, bool writeable)
|
|
{
|
|
auto lambda = [&] (Dataspace_component *ds) -> Local_addr {
|
|
if (!ds)
|
|
throw Invalid_dataspace();
|
|
|
|
if (size == 0)
|
|
size = ds->size();
|
|
|
|
size_t page_rounded_size = (size + get_page_size() - 1) & get_page_mask();
|
|
|
|
if (use_local_addr) {
|
|
error("Parameter 'use_local_addr' not supported within core");
|
|
return nullptr;
|
|
}
|
|
|
|
if (offset) {
|
|
error("Parameter 'offset' not supported within core");
|
|
return nullptr;
|
|
}
|
|
|
|
/* allocate range in core's virtual address space */
|
|
void *virt_addr;
|
|
if (!platform().region_alloc().alloc_aligned(page_rounded_size, &virt_addr,
|
|
get_page_size_log2()).ok()) {
|
|
error("could not allocate virtual address range in core of size ",
|
|
page_rounded_size);
|
|
return nullptr;
|
|
}
|
|
|
|
using namespace Hw;
|
|
|
|
/* map the dataspace's physical pages to corresponding virtual addresses */
|
|
unsigned num_pages = page_rounded_size >> get_page_size_log2();
|
|
Page_flags const flags { (writeable && ds->writable()) ? RW : RO,
|
|
NO_EXEC, KERN, GLOBAL,
|
|
ds->io_mem() ? DEVICE : RAM,
|
|
ds->cacheability() };
|
|
if (!map_local(ds->phys_addr(), (addr_t)virt_addr, num_pages, flags))
|
|
return nullptr;
|
|
|
|
return virt_addr;
|
|
};
|
|
return _ep.apply(ds_cap, lambda);
|
|
}
|
|
|
|
|
|
void Core_region_map::detach(Local_addr) { }
|