6b289a1423
This patch replaces the former prominent use of pointers by references wherever feasible. This has the following benefits: * The contract between caller and callee becomes more obvious. When passing a reference, the contract says that the argument cannot be a null pointer. The caller is responsible to ensure that. Therefore, the use of reference eliminates the need to add defensive null-pointer checks at the callee site, which sometimes merely exist to be on the safe side. The bottom line is that the code becomes easier to follow. * Reference members must be initialized via an object initializer, which promotes a programming style that avoids intermediate object- construction states. Within core, there are still a few pointers as member variables left though. E.g., caused by the late association of 'Platform_thread' objects with their 'Platform_pd' objects. * If no pointers are present as member variables, we don't need to manually provide declarations of a private copy constructor and an assignment operator to avoid -Weffc++ errors "class ... has pointer data members [-Werror=effc++]". This patch also changes a few system bindings on NOVA and Fiasco.OC, e.g., the return value of the global 'cap_map' accessor has become a reference. Hence, the patch touches a few places outside of core. Fixes #3135
50 lines
1.1 KiB
C++
50 lines
1.1 KiB
C++
/*
|
|
* \brief Core implementation of the CPU session interface extension
|
|
* \author Norman Feske
|
|
* \date 2016-04-21
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
/* Genode includes */
|
|
#include <base/stdint.h>
|
|
|
|
/* core-local includes */
|
|
#include <native_cpu_component.h>
|
|
#include <cpu_session_component.h>
|
|
|
|
using namespace Genode;
|
|
|
|
|
|
void Native_cpu_component::thread_type(Thread_capability thread_cap,
|
|
Thread_type thread_type,
|
|
Exception_base exception_base)
|
|
{
|
|
auto lambda = [&] (Cpu_thread_component *thread) {
|
|
if (!thread)
|
|
return;
|
|
|
|
thread->platform_thread().thread_type(thread_type, exception_base);
|
|
};
|
|
|
|
_thread_ep.apply(thread_cap, lambda);
|
|
}
|
|
|
|
Native_cpu_component::Native_cpu_component(Cpu_session_component &cpu_session, char const *)
|
|
:
|
|
_cpu_session(cpu_session), _thread_ep(_cpu_session._thread_ep)
|
|
{
|
|
_thread_ep.manage(this);
|
|
}
|
|
|
|
|
|
Genode::Native_cpu_component::~Native_cpu_component()
|
|
{
|
|
_thread_ep.dissolve(this);
|
|
}
|