From f1427fc02a83fbf266bda04e70c8ee92b34da935 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josef=20S=C3=B6ntgen?= Date: Sat, 9 May 2020 20:42:49 +0200 Subject: [PATCH] dde_bsd: remove configration attributes The driver always opens the audio device in duplex mode, i.e., playback and recording. Setting the 'playback' or 'recording' attribute only influnces the service announcement. Due to changes made in a more recent OpenBSD release recording must be set enabled explicitly anyway. Since we already provide the interface that mirrors the one used by OpenBSD 1:1 in the configuration use that and the remove the additional config attributes. Fixes #3757. --- repos/dde_bsd/src/drivers/audio/main.cc | 28 ++++++++----------------- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/repos/dde_bsd/src/drivers/audio/main.cc b/repos/dde_bsd/src/drivers/audio/main.cc index 6214a7676..fa2eb2790 100644 --- a/repos/dde_bsd/src/drivers/audio/main.cc +++ b/repos/dde_bsd/src/drivers/audio/main.cc @@ -508,26 +508,16 @@ struct Main return; } - /* playback */ - if (config.xml().attribute_value("playback", true)) { - static Audio_out::Out out(env); - Audio::play_sigh(out.sigh()); - static Audio_out::Root out_root(env, heap, out.data_avail()); - env.parent().announce(env.ep().manage(out_root)); + static Audio_out::Out out(env); + Audio::play_sigh(out.sigh()); + static Audio_out::Root out_root(env, heap, out.data_avail()); + env.parent().announce(env.ep().manage(out_root)); - Genode::log("--- BSD Audio driver enable playback ---"); - } - - /* recording */ - if (config.xml().attribute_value("recording", true)) { - static Audio_in::In in(env); - Audio::record_sigh(in.sigh()); - static Audio_in::Root in_root(env, heap, - Genode::Signal_context_capability()); - env.parent().announce(env.ep().manage(in_root)); - - Genode::log("--- BSD Audio driver enable recording ---"); - } + static Audio_in::In in(env); + Audio::record_sigh(in.sigh()); + static Audio_in::Root in_root(env, heap, + Genode::Signal_context_capability()); + env.parent().announce(env.ep().manage(in_root)); config.sigh(config_update_dispatcher); }