From eefe91ee4100806bb196ab1e18946bc250a367e9 Mon Sep 17 00:00:00 2001 From: Norman Feske Date: Fri, 27 Sep 2019 17:58:50 +0200 Subject: [PATCH] depot_download_manager: no mtime update in extract With the added modification-time support in the libc, the extract tool requires a timer session, which is not plausible for the purpose of the program. This behavior stems from the fact that the libc implicitly writes the mtime when closing a written file. For this update, it implicitly calls 'clock_gettime', which in turn initializes the timer subsystem within the libc (creating a timer session). For the extract tool, the implicitly updated mtime is useless because the extract tool overwrites this modification time with the mtime stored in the archive anyway. However, the dependency from a timer service remains. This patch explicitly disables the libc's implicit updating of the file-modification when closing a written file. Issue #1784 --- repos/gems/src/app/depot_download_manager/gen_extract.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/repos/gems/src/app/depot_download_manager/gen_extract.cc b/repos/gems/src/app/depot_download_manager/gen_extract.cc index 2ea6504a8..4c1c66379 100644 --- a/repos/gems/src/app/depot_download_manager/gen_extract.cc +++ b/repos/gems/src/app/depot_download_manager/gen_extract.cc @@ -25,10 +25,11 @@ void Depot_download_manager::gen_extract_start_content(Xml_generator &xml, xml.attribute("verbose", "yes"); xml.node("libc", [&] () { - xml.attribute("stdout", "/dev/log"); - xml.attribute("stderr", "/dev/log"); - xml.attribute("rtc", "/dev/null"); - xml.attribute("cwd", user_path); + xml.attribute("stdout", "/dev/log"); + xml.attribute("stderr", "/dev/log"); + xml.attribute("rtc", "/dev/null"); + xml.attribute("cwd", user_path); + xml.attribute("update_mtime", "no"); }); xml.node("vfs", [&] () {