ehmry/genode
ehmry
/
genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libc: prune session labels of forked processes 

This patch reduces the size of session labels for all services other
than LOG, keeping only the last element. This avoids exceeding the
maximum label length in the presence of deep fork hierarchies, e.g., for
running the tool chain.

Fixes #3700
This commit is contained in:
Norman Feske 2020-03-13 21:06:39 +01:00
parent dd524b56fa
commit ee6d38a770
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
repos/libports/src/lib/libc/fork.cc
View File

@ -496,15 +496,19 @@ struct Libc::Forked_child : Child_policy, Child_ready
if (_state == State::STARTING_UP && name == Clone_session::service_name())
service_ptr = &_local_clone_service.service;
if (name == Rom_session::service_name()) {
/*
* Strip off the originating child name to allow the application of
* routing rules based on the leading path elements, regardless
* of which child in the process hierarchy requests a ROM.
*/
/*
* Strip off the originating child name regardless of which child in
* the process hierarchy requests the session. This way, we avoid
* overly long labels in the presence of deep fork nesting levels.
*
* We keep the label intact only for the LOG sessions to retain
* unambiguous debug messages.
*/
if (name != "LOG")
rewritten_label = label.last_element();
if (name == Rom_session::service_name()) {
try { service_ptr = &_local_rom_services.matching_service(name, label); }
catch (...) { }