ehmry/genode
ehmry/genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

qemu-usb: avoid operating on stale memory

Browse Source 
during for loop in garbage_collect

Issue #2362
This commit is contained in:
Alexander Boettcher 2017-03-31 18:08:22 +02:00 committed by Christian Helmuth
parent 760c04c53a
commit ecc98c293e
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
repos/libports/src/lib/qemu-usb/host.cc
View File

@ -538,12 +538,15 @@ struct Usb_devices : List<Usb_host_device>
void _garbage_collect()
{
for (Usb_host_device *d = first(); d; d = d->next()) {
if (d->deleted == false)
for (Usb_host_device *next = first(); next;) {
Usb_host_device *current = next;
next = current->next();
if (current->deleted == false)
continue;
remove(d);
Genode::destroy(_alloc, d);
remove(current);
Genode::destroy(_alloc, current);
}
}