ehmry/genode
ehmry/genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Delete Sliced_heap::Block object when freeing.

Browse Source 
When a portion of the sliced heap gets freed, the corresponding block
gets removed from the list of blocks, and it's dataspace containing the
block gets detached, but it's destructor never gets called. This leads
to leaking capabilities, when Native_capability is implemented as
smart-pointer, because the destructor of Ram_dataspace_capability that
is part of the Block object gets never called.
This commit is contained in:
Stefan Kalkowski 2012-05-02 12:10:55 +02:00 committed by Norman Feske
parent ca004658d9
commit d1c7d64c2c
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
base/src/base/heap/sliced_heap.cc
View File

@ -29,6 +29,8 @@ namespace Genode {
inline void *operator new(size_t size, void *at_addr) {
return at_addr; }
inline void operator delete (void*) { }
/**
* Constructor
*/
@ -106,6 +108,7 @@ void Sliced_heap::free(void *addr, size_t size)
_block_list.remove(b);
_consumed -= b->size();
Ram_dataspace_capability ds_cap = b->ds_cap();
delete b;
_rm_session->detach(b);
_ram_session->free(ds_cap);
}