ehmry/genode
ehmry
/
genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

init: limit rate of periodic reports by 'delay_ms' 

This is a follow-up patch to "init: periodic state updates if sensible".
In situations where the report rate is deliberately limited via the
'delay_ms' attribute while also reporting child-resource stats, we don't
want generate reports at a fixed rate of one second. This patch limits
the rate according to the 'delay_ms' value.
This commit is contained in:
Norman Feske 2017-11-09 17:13:39 +01:00 committed by Christian Helmuth
parent d2c7cfa5fa
commit cda71e198f
1 changed files with 34 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
repos/os/src/init/state_reporter.h
View File

@ -47,6 +47,9 @@ class Init::State_reporter : public Report_update_trigger
unsigned _report_delay_ms = 0;
/* interval used when child-ram reporting is enabled */
unsigned _report_period_ms = 0;
/* version string from config, to be reflected in the report */
typedef String<64> Version;
Version _version;
@ -139,16 +142,37 @@ class Init::State_reporter : public Report_update_trigger
if (trigger_update)
trigger_report_update();
if (_report_detail->child_ram() || _report_detail->child_caps()) {
if (!_timer_periodic.constructed()) {
_timer_periodic.construct(_env);
_timer_periodic->sigh(_timer_periodic_handler);
}
_timer_periodic->trigger_periodic(1000*1000);
} else {
if (_timer_periodic.constructed()) {
_timer_periodic.destruct();
}
/*
* If the report features information about child-RAM quotas, we
* update the report periodically. Even in the absence of any other
* report-triggering event, a child may consume/free RAM from its
* RAM session without any interplay with init. The periodic
* reports ensure that such changes are reflected by init's state
* report.
*
* By default, the interval is one second. However, when the
* 'delay_ms' attribute is defined with a higher value than that,
* the user intends to limit the rate of state reports. If so, we
* use the value of 'delay_ms' as interval.
*/
unsigned const period_ms = max(1000U, _report_delay_ms);
bool const period_changed = (_report_period_ms != period_ms);
bool const report_periodically = _report_detail->child_ram()
|| _report_detail->child_caps();
if (report_periodically && !_timer_periodic.constructed()) {
_timer_periodic.construct(_env);
_timer_periodic->sigh(_timer_periodic_handler);
}
if (!report_periodically && _timer_periodic.constructed()) {
_report_period_ms = 0;
_timer_periodic.destruct();
}
if (period_changed && _timer_periodic.constructed()) {
_report_period_ms = period_ms;
_timer_periodic->trigger_periodic(1000*_report_period_ms);
}
}