ehmry/genode
ehmry
/
genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

init: defer immediate restart of abandoned child 

While a child is abandoned, we must limit the start of anothers with
the same name. Otherwise - of the child has startup problems - a number
of abandoned children with the same name may queue up. This becomes a
problem whenever the child destruction depends on an asynchronous
service that provides an env session for the children. If the service is
unable to keep up with the session requests (both create and close),
the queue of abandoned children becomes unbounded. Limiting the child
creation rate to one abandoned child per name mitigates this problem.
This commit is contained in:
Norman Feske 2018-06-07 18:22:08 +02:00 committed by Christian Helmuth
parent 6ab259d642
commit b96f0fa2df
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
repos/os/src/init/main.cc
View File

@ -356,15 +356,26 @@ void Init::Main::_handle_config()
try {
_config_xml.for_each_sub_node("start", [&] (Xml_node start_node) {
/* skip start node if corresponding child already exists */
bool exists = false;
unsigned num_abandoned = 0;
_children.for_each_child([&] (Child const &child) {
if (!child.abandoned()
&& child.name() == start_node.attribute_value("name", Child_policy::Name()))
exists = true; });
if (exists) {
if (child.name() == start_node.attribute_value("name", Child_policy::Name())) {
if (child.abandoned())
num_abandoned++;
else
exists = true;
}
});
/* skip start node if corresponding child already exists */
if (exists)
return;
/* prevent queuing up abandoned children with the same name */
if (num_abandoned > 1)
return;
}
if (used_ram.value > avail_ram.value) {
error("RAM exhausted while starting childen");