ehmry/genode
ehmry
/
genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

themed_decorator: optionally disable decorations 

This patch adds the boolean policy attribute "decoration", which
controls whether window decorations are presented or not. It is enabled
by default. By setting the attribute to "no", matching windows appear
without any border, which is desireable for Sculpt's component graph.

Issue #3096
This commit is contained in:
Norman Feske 2018-12-26 14:34:21 +01:00
parent 296a409a29
commit a3bbef5f21
2 changed files with 27 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
repos/gems/src/app/themed_decorator/config.h
View File

@ -39,6 +39,17 @@ class Decorator::Config
Config(Genode::Xml_node node) : _config(node) {}
bool show_decoration(Window_title const &title) const
{
try {
Genode::Session_policy policy(title, _config);
return policy.attribute_value("decoration", true);
} catch (Genode::Session_policy::No_policy_defined) { }
return true;
}
/**
* Return the base color of the window with the specified title
*/

24
repos/gems/src/app/themed_decorator/window.h
View File

@ -239,6 +239,8 @@ class Decorator::Window : public Window_base, public Animator::Item
Color _color() const { return Color(_r >> 4, _g >> 4, _b >> 4); }
bool _show_decoration = _config.show_decoration(_title);
/**
* Nitpicker session that contains the upper and lower window
* decorations.
@ -327,10 +329,12 @@ class Decorator::Window : public Window_base, public Animator::Item
void _stack_decoration_views()
{
_top_view.stack(_content_view.handle());
_left_view.stack(_top_view.handle());
_right_view.stack(_left_view.handle());
_bottom_view.stack(_right_view.handle());
if (_show_decoration) {
_top_view.stack(_content_view.handle());
_left_view.stack(_top_view.handle());
_right_view.stack(_left_view.handle());
_bottom_view.stack(_right_view.handle());
}
}
public:
@ -340,7 +344,7 @@ class Decorator::Window : public Window_base, public Animator::Item
:
Window_base(id),
Animator::Item(animator),
_env(env),_theme(theme), _animator(animator),
_env(env), _theme(theme), _animator(animator),
_nitpicker(nitpicker), _config(config)
{
_reallocate_nitpicker_buffers();
@ -368,7 +372,7 @@ class Decorator::Window : public Window_base, public Animator::Item
View_handle frontmost_view() const override
{
return _bottom_view.handle();
return _show_decoration ? _bottom_view.handle() : _content_view.handle();
}
Rect _decor_geometry() const
@ -425,6 +429,8 @@ class Decorator::Window : public Window_base, public Animator::Item
{
_assign_color(_config.base_color(_title));
animate();
_show_decoration = _config.show_decoration(_title);
}
bool update(Xml_node window_node) override
@ -467,14 +473,16 @@ class Decorator::Window : public Window_base, public Animator::Item
trigger_animation = true;
}
Window_title title = Decorator::string_attribute(window_node, "title",
Window_title("<untitled>"));
Window_title const title =
window_node.attribute_value("title", Window_title("<untitled>"));
if (_title != title) {
_title = title;
trigger_animation = true;
}
_show_decoration = _config.show_decoration(_title);
/* update color on title change as the title is used as policy selector */
Color const base_color = _config.base_color(_title);
if (_base_color != base_color) {