ehmry/genode
ehmry
/
genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "timer: apply PIT quirk to avoid high cpu load" 

This reverts commit edc03489b3.

Since commit

"timer: nova specific version of the service"

a nova specific timer is used and this quirk is not necessary anymore.

Issue #1211
This commit is contained in:
Alexander Boettcher 2014-07-19 10:05:45 +02:00 committed by Norman Feske
parent a46de84f89
commit a371fdab4f
1 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
repos/os/src/drivers/timer/include_pit/platform_timer.h
View File

@ -179,37 +179,6 @@ class Platform_timer
if (timeout_usec > max_timeout())
timeout_usec = max_timeout();
/*
* XXX Quirk - start
*
* On some x86 platforms, it happens that the system seems to slow
* down dramatically for some unclear reasons so far. When this
* happens, the handling of the timeout queue and reprogramming the
* next timeout takes so long that the timer IRQ will fire
* immediately after acknowledging it. This causes the timer
* service to run on a very high rate, which may utilize the CPU
* close to the maximum. We try to detect this condition by the
* following heuristic and apply this quirk, which programs the
* next timeout later in time - so that it will fire not
* immediately after acknowledging it.
*
* This quirk should be removed as soon as it is clear what
* triggers the phenomenon.
*/
enum { QUIRK_TIMEOUT_US = 2800 };
unsigned long now = curr_time();
asm volatile ("":::"memory");
unsigned long later = curr_time();
unsigned long diff = later - now;
if (diff > QUIRK_TIMEOUT_US) {
timeout_usec = diff * 6 > max_timeout() ? max_timeout() : diff * 6;
PERR("apply timer quirk - diff=%lu, timeout_usec=%lu",
diff, timeout_usec);
}
/* XXX Quirk - end */
_counter_init_value = (PIT_TICKS_PER_MSEC * timeout_usec)/1000;
_set_counter(_counter_init_value);
}