ehmry/genode
ehmry
/
genode
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gems/animator.h: use private 'List_element' 

This patch makes the use of 'List' invisible at the 'Animator'
interface. This allows users of the utility to keep 'Animator::Items' in
a custom 'List' with no aliasing problems.
This commit is contained in:
Norman Feske 2017-08-17 16:56:29 +02:00 committed by Christian Helmuth
parent e86758084c
commit 97e4af36b8
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
repos/gems/include/gems/animator.h
View File

@ -28,7 +28,7 @@ class Animator
friend class Item;
Genode::List<Item> _items;
Genode::List<Genode::List_element<Item> > _items;
public:
@ -41,10 +41,12 @@ class Animator
/**
* Interface to be implemented by animated objects
*/
class Animator::Item : public Genode::List<Item>::Element
class Animator::Item
{
private:
Genode::List_element<Item> _element { this };
Animator &_animator;
bool _animated = false;
@ -62,9 +64,9 @@ class Animator::Item : public Genode::List<Item>::Element
return;
if (animated)
_animator._items.insert(this);
_animator._items.insert(&_element);
else
_animator._items.remove(this);
_animator._items.remove(&_element);
_animated = animated;
}
@ -75,9 +77,9 @@ class Animator::Item : public Genode::List<Item>::Element
inline void Animator::animate()
{
for (Item *item = _items.first(); item; ) {
Item *next = item->next();
item->animate();
for (Genode::List_element<Item> *item = _items.first(); item; ) {
Genode::List_element<Item> *next = item->next();
item->object()->animate();
item = next;
}
}