From 6ae98e2e6d501416e98eee3af990751a819c250c Mon Sep 17 00:00:00 2001 From: Norman Feske Date: Thu, 2 Jan 2020 20:23:03 +0100 Subject: [PATCH] base: mark Parent::Close_result with [[nodiscard]] --- repos/base/include/parent/parent.h | 2 +- repos/base/src/lib/base/child.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/repos/base/include/parent/parent.h b/repos/base/include/parent/parent.h index 92cfd86c0..7379342e5 100644 --- a/repos/base/include/parent/parent.h +++ b/repos/base/include/parent/parent.h @@ -200,7 +200,7 @@ class Genode::Parent virtual Upgrade_result upgrade(Client::Id to_session, Upgrade_args const &args) = 0; - enum Close_result { CLOSE_DONE, CLOSE_PENDING }; + enum [[nodiscard]] Close_result { CLOSE_DONE, CLOSE_PENDING }; /** * Close session diff --git a/repos/base/src/lib/base/child.cc b/repos/base/src/lib/base/child.cc index ca23775fe..181e61626 100644 --- a/repos/base/src/lib/base/child.cc +++ b/repos/base/src/lib/base/child.cc @@ -867,7 +867,7 @@ void Child::close_all_sessions() * running. */ while (unsigned long id_value = any_cpu_session_id(_id_space).value) - close(Parent::Client::Id{id_value}); + (void)close(Parent::Client::Id{id_value}); _initial_thread.destruct(); @@ -921,7 +921,7 @@ void Child::close_all_sessions() auto close_fn = [&] (Session_state &session) { session.closed_callback = nullptr; session.ready_callback = nullptr; - _close(session); + (void)_close(session); }; while (_id_space.apply_any(close_fn));